Repository navigation
Commit 91652a8
authored
fix(ios): publish captured keyboard geometry in the app's orientation space (#2653)
iOS hosts the system keyboard in the device's native portrait space, so in landscape its whole
subtree arrives quarter-turned: a key measured 45x72 at x 154 in an 874x402 app, drawing a strip down
the left edge where the screenshot shows a 724x204 band docked at y 198. Rules that read those numbers
refused app content the keyboard was nowhere near and let a tap land on a key (#2612).
The Apple runner now reads the app's interface orientation at capture time and publishes every rect
under a turned surface host in the app's space, through the exact inverse of the rotation its
synthesized touches rotate forward by, so a reported rect and a performed tap cannot disagree about
which pixel is which. One table serves both directions, and the new coordinate-space module owns it.
An orientation that names no quarter turn declares nothing, and the collapsed-tab expansion, which
reads live element frames, stays out of a declared native space rather than turning them twice.
The Simulator AX bridge reader carries no interface orientation, so it counts surface hosts reporting
the app box quarter-turned and refuses that capture with window-coordinate-space-unresolved; the route
serves the runner for that capture alone rather than retiring the app generation, so the next capture
of a healthy app still uses the bridge. Both languages replay one table,
contracts/fixtures/window-coordinate-space.json, which pins the turn and the box that declares it.1 parent 690f690 commit 91652a8
21 files changed
Lines changed: 1642 additions & 188 deletions
File tree
- apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests
- contracts/fixtures
- docs/adr
- packages
- contracts/src
- platform-apple/src
- snapshot-source
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
22 | 37 | | |
23 | 38 | | |
24 | 39 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
332 | | - | |
| 332 | + | |
333 | 333 | | |
334 | 334 | | |
335 | 335 | | |
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
378 | | - | |
379 | | - | |
| 377 | + | |
| 378 | + | |
380 | 379 | | |
381 | 380 | | |
382 | 381 | | |
383 | | - | |
384 | | - | |
385 | | - | |
| 382 | + | |
| 383 | + | |
386 | 384 | | |
387 | 385 | | |
388 | 386 | | |
389 | 387 | | |
390 | | - | |
| 388 | + | |
391 | 389 | | |
392 | 390 | | |
393 | 391 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
219 | | - | |
| 219 | + | |
| 220 | + | |
220 | 221 | | |
221 | 222 | | |
222 | 223 | | |
223 | | - | |
| 224 | + | |
| 225 | + | |
224 | 226 | | |
225 | 227 | | |
226 | 228 | | |
| |||
269 | 271 | | |
270 | 272 | | |
271 | 273 | | |
272 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
273 | 282 | | |
274 | 283 | | |
275 | | - | |
| 284 | + | |
276 | 285 | | |
277 | 286 | | |
278 | | - | |
| 287 | + | |
279 | 288 | | |
280 | 289 | | |
281 | 290 | | |
282 | 291 | | |
283 | | - | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
284 | 296 | | |
285 | | - | |
286 | | - | |
| 297 | + | |
| 298 | + | |
287 | 299 | | |
288 | | - | |
| 300 | + | |
289 | 301 | | |
290 | 302 | | |
291 | | - | |
| 303 | + | |
292 | 304 | | |
293 | 305 | | |
294 | 306 | | |
| |||
686 | 698 | | |
687 | 699 | | |
688 | 700 | | |
689 | | - | |
| 701 | + | |
| 702 | + | |
690 | 703 | | |
691 | 704 | | |
692 | 705 | | |
| |||
720 | 733 | | |
721 | 734 | | |
722 | 735 | | |
723 | | - | |
| 736 | + | |
| 737 | + | |
724 | 738 | | |
725 | 739 | | |
726 | 740 | | |
| |||
798 | 812 | | |
799 | 813 | | |
800 | 814 | | |
801 | | - | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
802 | 818 | | |
803 | 819 | | |
804 | 820 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | 14 | | |
25 | 15 | | |
26 | 16 | | |
| |||
497 | 487 | | |
498 | 488 | | |
499 | 489 | | |
500 | | - | |
501 | | - | |
502 | | - | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | 490 | | |
545 | 491 | | |
546 | 492 | | |
| |||
569 | 515 | | |
570 | 516 | | |
571 | 517 | | |
572 | | - | |
573 | | - | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
574 | 528 | | |
575 | 529 | | |
576 | 530 | | |
| |||
644 | 598 | | |
645 | 599 | | |
646 | 600 | | |
647 | | - | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
648 | 606 | | |
649 | 607 | | |
650 | 608 | | |
| |||
1055 | 1013 | | |
1056 | 1014 | | |
1057 | 1015 | | |
1058 | | - | |
1059 | | - | |
1060 | | - | |
| 1016 | + | |
| 1017 | + | |
1061 | 1018 | | |
1062 | 1019 | | |
1063 | 1020 | | |
| |||
1178 | 1135 | | |
1179 | 1136 | | |
1180 | 1137 | | |
1181 | | - | |
1182 | | - | |
1183 | | - | |
1184 | | - | |
1185 | | - | |
1186 | | - | |
1187 | | - | |
1188 | | - | |
1189 | | - | |
1190 | | - | |
1191 | | - | |
1192 | | - | |
1193 | | - | |
1194 | | - | |
1195 | | - | |
1196 | | - | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | | - | |
1201 | | - | |
1202 | | - | |
1203 | | - | |
1204 | | - | |
1205 | | - | |
1206 | | - | |
1207 | | - | |
1208 | | - | |
1209 | | - | |
1210 | | - | |
1211 | | - | |
1212 | | - | |
1213 | | - | |
1214 | | - | |
1215 | | - | |
1216 | | - | |
1217 | | - | |
1218 | | - | |
1219 | | - | |
1220 | | - | |
1221 | | - | |
1222 | | - | |
1223 | | - | |
1224 | | - | |
1225 | | - | |
1226 | | - | |
1227 | | - | |
1228 | 1138 | | |
1229 | 1139 | | |
1230 | 1140 | | |
| |||
0 commit comments