Repository navigation
Commit 8f84232
committed
fix(ci): run the three checks no workflow was running
`check:tmpdir-leaks`, `check:tmpdir-leaks:test` and `test:fixture-cache` are
real package scripts with real assertions that no CI lane executed. All three
are reachable only through `check:unit`, an aggregate no workflow invokes, so
a regression in any of them could not fail a PR — and a check that silently
stops running looks exactly like a green build.
Verified by transitive script reachability over every workflow and composite
action on main: zero references to any of the three anywhere in .github.
Placement:
- `check:tmpdir-leaks` joins Coverage, the lane whose instrumented suite is
what would leak a run directory.
- `check:tmpdir-leaks:test` joins Layering Guard rather than sitting next to
the check it covers. vitest-tmpdir-global-setup.test.ts proves the lifecycle
by spawning a real nested `vitest run`, and Coverage already loses runs to
worker-fork teardown errors; starting a nested Vitest beside the full
instrumented suite is a contention risk with nothing to gain.
- `test:fixture-cache` joins Integration Tests, beside the fixture-app
fallback smoke that covers the same artifact contract.
All three pass at this commit, so this wires green gates rather than red ones.
`check:tmpdir-leaks` was also shown non-vacuous: planting an abandoned
agent-device-test-run-* directory makes it fail and name the directory.
Part of #1429, which stays open for the ownership proof that would have caught
this class automatically.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01SkS4S8XXrfkJ8TD1VBKkvJ1 parent f98814f commit 8f84232
1 file changed
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
119 | 130 | | |
120 | 131 | | |
121 | 132 | | |
| |||
287 | 298 | | |
288 | 299 | | |
289 | 300 | | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
290 | 308 | | |
291 | 309 | | |
292 | 310 | | |
| |||
372 | 390 | | |
373 | 391 | | |
374 | 392 | | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
375 | 398 | | |
376 | 399 | | |
377 | 400 | | |
| |||
0 commit comments