Skip to content

Commit 8f84232

Browse files
committed
fix(ci): run the three checks no workflow was running
`check:tmpdir-leaks`, `check:tmpdir-leaks:test` and `test:fixture-cache` are real package scripts with real assertions that no CI lane executed. All three are reachable only through `check:unit`, an aggregate no workflow invokes, so a regression in any of them could not fail a PR — and a check that silently stops running looks exactly like a green build. Verified by transitive script reachability over every workflow and composite action on main: zero references to any of the three anywhere in .github. Placement: - `check:tmpdir-leaks` joins Coverage, the lane whose instrumented suite is what would leak a run directory. - `check:tmpdir-leaks:test` joins Layering Guard rather than sitting next to the check it covers. vitest-tmpdir-global-setup.test.ts proves the lifecycle by spawning a real nested `vitest run`, and Coverage already loses runs to worker-fork teardown errors; starting a nested Vitest beside the full instrumented suite is a contention risk with nothing to gain. - `test:fixture-cache` joins Integration Tests, beside the fixture-app fallback smoke that covers the same artifact contract. All three pass at this commit, so this wires green gates rather than red ones. `check:tmpdir-leaks` was also shown non-vacuous: planting an abandoned agent-device-test-run-* directory makes it fail and name the directory. Part of #1429, which stays open for the ownership proof that would have caught this class automatically. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01SkS4S8XXrfkJ8TD1VBKkvJ
1 parent f98814f commit 8f84232

1 file changed

Lines changed: 23 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,17 @@ jobs:
116116
# rather than in its own job so the two can never be green independently.
117117
run: pnpm depgraph:test
118118

119+
# Tests for the TMPDIR redirection itself, hidden the same way as the check above.
120+
#
121+
# Deliberately NOT in Coverage next to `check:tmpdir-leaks`, where the subject matter
122+
# would put it: vitest-tmpdir-global-setup.test.ts proves the lifecycle by spawning a
123+
# real nested `vitest run`, and the Coverage lane already loses runs to
124+
# `[vitest-pool]: Worker forks emitted error` when a fork is slow to terminate.
125+
# Starting a nested Vitest seconds before the full instrumented suite is a contention
126+
# risk with nothing to gain.
127+
- name: Check the tmpdir redirection model
128+
run: pnpm check:tmpdir-leaks:test
129+
119130
affected-selector:
120131
name: Affected-check Selector
121132
runs-on: ubuntu-latest
@@ -287,6 +298,13 @@ jobs:
287298
OUTPUT_ECONOMY_BASE: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.before }}
288299
run: pnpm test:coverage:ci
289300

301+
# The TMPDIR redirection both test lanes depend on (#1593/#1595). The check is a real
302+
# package script that no workflow ran: it is reachable only through `check:unit`, an
303+
# aggregate CI never invokes, so a leak regression could not fail a PR. Placed here
304+
# because this is the lane whose instrumented suite would leak a run directory.
305+
- name: Check for leaked temp directories
306+
run: pnpm check:tmpdir-leaks
307+
290308
- name: Upload contention-retry envelope
291309
if: always()
292310
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
@@ -372,6 +390,11 @@ jobs:
372390
- name: Setup-fixture-app cache-failure fallback
373391
run: sh ./test/scripts/setup-fixture-app-fallback-smoke.sh
374392

393+
# The trusted-artifact contract the device lanes rely on to decide a cached fixture
394+
# app is the one this commit expects. A real test file that no workflow ran.
395+
- name: Check the trusted fixture-artifact contract
396+
run: pnpm test:fixture-cache
397+
375398
web-smoke:
376399
name: Web Platform Smoke
377400
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)