Repository navigation
Commit 8c966f3
authored
* test(daemon): pin the acting route's own ambiguity issuance; narrow the rule's docblock
The review's two follow-ups, both confirmed at c6acd1e:
1) The acting seam had no test of its own. Deleting the touch runtime's
consumed-capture slot degraded every press/fill ambiguity to count-only
with no test red -- the existing press test pressed an is-minted ref,
traveling the selector-route seam. An ambiguous label= press through
handleInteractionCommands now asserts its OWN refusal carries
refsGeneration and a refFrameScope equal to the printed candidate
bodies. Mutation-checked: removing the slot fills makes exactly this
test fail.
2) The rule's docblock claimed every AMBIGUOUS_MATCH producer runs
through the helper; find's refusal (buildAmbiguousMatchError, #1597)
prints candidates without issuing them and never called it. Narrowed
to the routes that consume the rule, with the find shape named and its
contract stated: it prints no refsGeneration and its hint routes the
caller to narrow the locator, so it advertises no issued-ref
affordance. Routing find through the rule would make its candidates
issuable -- a separate contract change, left to the maintainer.
* docs(daemon): state find's missing generation pin, not an affordance claim
The review nit was right that the old phrasing leaned on an inference
("advertises no issued-ref affordance") that a reader could overread as
"find's candidates cannot be acted on" -- they are printed as ordinary
snapshot lines, and a plain ref against an unrelated complete frame is a
pre-existing admission the rule does not govern. The builder's own
message ("Use a more specific locator or selector.") and absent
refsGeneration remain the facts; state those directly and defer the
issuance question as the contract decision it is.
1 parent c7b534f commit 8c966f3
2 files changed
Lines changed: 94 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
30 | 33 | | |
31 | 34 | | |
32 | 35 | | |
| |||
38 | 41 | | |
39 | 42 | | |
40 | 43 | | |
41 | | - | |
42 | | - | |
43 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | 50 | | |
| |||
52 | 56 | | |
53 | 57 | | |
54 | 58 | | |
| 59 | + | |
55 | 60 | | |
56 | 61 | | |
57 | 62 | | |
| |||
233 | 238 | | |
234 | 239 | | |
235 | 240 | | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
149 | 153 | | |
150 | 154 | | |
151 | 155 | | |
| |||
0 commit comments