Skip to content

Commit 8889a17

Browse files
committed
test: move packaged metro smoke to integration
1 parent 20c5f0f commit 8889a17

5 files changed

Lines changed: 16 additions & 513 deletions

File tree

‎fallow-baselines/dupes.json‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
"src/__tests__/client-companion-tunnel-worker.test.ts:196-207|test/integration/installed-package-metro.test.ts:13-18",
6262
"src/__tests__/client-companion-tunnel-worker.test.ts:205-212|test/integration/device-lab/device-lab-android-lifecycle.test.ts:901-908",
6363
"src/__tests__/client-companion-tunnel-worker.test.ts:209-220|test/integration/installed-package-metro.test.ts:18-28",
64-
"src/__tests__/client-companion-tunnel-worker.test.ts:397-401|test/scripts/metro-prepare-packaged-smoke.mjs:89-93",
6564
"src/__tests__/client-companion-tunnel-worker.test.ts:403-416|src/__tests__/client-companion-tunnel-worker.test.ts:622-635|src/__tests__/client-companion-tunnel-worker.test.ts:673-686",
6665
"src/__tests__/client-companion-tunnel-worker.test.ts:512-533|src/__tests__/client-companion-tunnel-worker.test.ts:662-683",
6766
"src/__tests__/client-companion-tunnel-worker.test.ts:512-526|src/__tests__/client-companion-tunnel-worker.test.ts:600-625|src/__tests__/client-companion-tunnel-worker.test.ts:662-676",
@@ -502,8 +501,7 @@
502501
"src/utils/__tests__/device.test.ts:76-83|src/utils/__tests__/device.test.ts:85-94",
503502
"src/utils/__tests__/device.test.ts:161-170|src/utils/__tests__/device.test.ts:214-223",
504503
"src/utils/__tests__/device.test.ts:173-189|src/utils/__tests__/device.test.ts:195-210",
505-
"src/utils/__tests__/exec.test.ts:77-90|test/scripts/metro-prepare-packaged-smoke.mjs:124-145",
506-
"src/utils/__tests__/exec.test.ts:81-88|src/utils/exec.ts:336-344|test/scripts/metro-prepare-packaged-smoke.mjs:130-137",
504+
"src/utils/__tests__/exec.test.ts:81-88|src/utils/exec.ts:336-344",
507505
"src/utils/__tests__/mobile-snapshot-semantics.test.ts:338-353|src/utils/__tests__/mobile-snapshot-semantics.test.ts:86-101",
508506
"src/utils/__tests__/mobile-snapshot-semantics.test.ts:153-172|src/utils/__tests__/mobile-snapshot-semantics.test.ts:179-197",
509507
"src/utils/__tests__/mobile-snapshot-semantics.test.ts:284-309|src/utils/__tests__/mobile-snapshot-semantics.test.ts:320-345",
@@ -552,13 +550,9 @@
552550
"test/integration/device-lab/device-lab-ios-lifecycle.test.ts:69-86|test/integration/device-lab/device-lab-macos-desktop.test.ts:20-37",
553551
"test/integration/device-lab/device-lab-ios-record-trace.test.ts:217-228|test/integration/device-lab/device-lab-ios-record-trace.test.ts:69-80",
554552
"test/integration/device-lab/loopback.ts:6-19|test/integration/smoke-daemon-http.test.ts:184-197|test/integration/smoke-open-remote-config.test.ts:86-99",
555-
"test/integration/device-lab/loopback.ts:10-18|test/integration/smoke-daemon-http.test.ts:188-196|test/integration/smoke-open-remote-config.test.ts:90-98|test/scripts/metro-prepare-packaged-smoke.mjs:56-62",
556553
"test/integration/installed-package-metro.test.ts:15-22|test/integration/smoke-open-remote-config.test.ts:102-109",
557554
"test/integration/installed-package-metro.test.ts:29-36|test/integration/smoke-open-remote-config.test.ts:115-122",
558555
"test/integration/smoke-daemon-http.test.ts:173-197|test/integration/smoke-open-remote-config.test.ts:78-99",
559-
"test/integration/smoke-daemon-http.test.ts:208-216|test/integration/smoke-daemon-http.test.ts:292-300",
560-
"test/integration/smoke-open-remote-config.test.ts:103-111|test/scripts/metro-prepare-packaged-smoke.mjs:66-74",
561-
"test/integration/smoke-open-remote-config.test.ts:146-170|test/scripts/metro-prepare-packaged-smoke.mjs:200-214",
562-
"test/scripts/metro-prepare-packaged-smoke.mjs:217-226|test/scripts/metro-prepare-packaged-smoke.mjs:245-254"
556+
"test/integration/smoke-daemon-http.test.ts:208-216|test/integration/smoke-daemon-http.test.ts:292-300"
563557
]
564558
}

‎fallow-baselines/health.json‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -941,14 +941,6 @@
941941
"crap_moderate": {
942942
"count": 4
943943
}
944-
},
945-
"test/scripts/metro-prepare-packaged-smoke.mjs": {
946-
"crap_critical": {
947-
"count": 1
948-
},
949-
"crap_moderate": {
950-
"count": 1
951-
}
952944
}
953945
},
954946
"runtime_coverage_findings": [],
@@ -960,27 +952,27 @@
960952
"src/daemon/handlers/session-replay-script.ts:complexity",
961953
"src/commands/selector-read-utils.ts:high impact",
962954
"src/daemon/handlers/session-replay-heal.ts:complexity",
963-
"src/daemon/context.ts:high impact",
964955
"src/cli/commands/connection-runtime.ts:complexity",
965956
"src/daemon/android-snapshot-freshness.ts:high impact",
957+
"src/daemon/context.ts:high impact",
966958
"src/daemon/config.ts:high impact",
967959
"src/daemon/script-utils.ts:high impact",
968960
"src/platforms/boot-diagnostics.ts:complexity",
969961
"src/daemon/handlers/snapshot-alert.ts:complexity",
970962
"src/daemon/handlers/session-open-target.ts:high impact",
971963
"src/utils/success-text.ts:high impact",
972-
"src/cli/commands/output.ts:untested risk",
973964
"src/daemon/handlers/install-source.ts:complexity",
965+
"src/cli/commands/output.ts:untested risk",
974966
"src/utils/snapshot-processing.ts:high impact",
975967
"src/utils/process-identity.ts:high impact",
976968
"src/utils/output.ts:high impact",
977969
"src/utils/snapshot-lines.ts:high impact",
978970
"src/platforms/ios/xml.ts:high impact",
979971
"src/daemon/handlers/session-state.ts:complexity",
972+
"src/platforms/linux/snapshot.ts:high impact",
980973
"src/daemon/handlers/session-open.ts:complexity",
981974
"src/utils/args.ts:high impact",
982975
"src/daemon/request-cancel.ts:high impact",
983-
"src/platforms/linux/snapshot.ts:high impact",
984976
"src/cli.ts:complexity",
985977
"src/client-metro.ts:complexity",
986978
"src/utils/selector-build.ts:high impact",

‎src/__tests__/client-metro-packaged.test.ts‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎test/integration/installed-package-metro.test.ts‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,16 @@ function packInstalledPackage(tempRoot: string): string {
6767
return path.join(packDir, tarballName);
6868
}
6969

70+
function ensureBuiltPackage(): void {
71+
const distMetroPath = path.join(repoRoot, 'dist', 'src', 'metro.js');
72+
if (fs.existsSync(distMetroPath)) return;
73+
74+
runCmdSync('pnpm', ['build'], {
75+
cwd: repoRoot,
76+
timeoutMs: SUBPROCESS_TIMEOUT_MS,
77+
});
78+
}
79+
7080
function extractInstalledPackage(tarballPath: string, consumerRoot: string): string {
7181
const nodeModulesRoot = path.join(consumerRoot, 'node_modules');
7282
fs.mkdirSync(nodeModulesRoot, { recursive: true });
@@ -119,12 +129,6 @@ function acceptWebSocket(socket: Duplex, key: string): void {
119129
}
120130

121131
test('installed package exposes Node APIs and packaged companion tunnel entrypoint', async (t) => {
122-
const distMetroPath = path.join(repoRoot, 'dist', 'src', 'metro.js');
123-
if (!fs.existsSync(distMetroPath)) {
124-
t.skip('run pnpm build before executing installed-package integration tests');
125-
return;
126-
}
127-
128132
const root = fs.mkdtempSync(path.join(os.tmpdir(), 'agent-device-installed-package-'));
129133
const consumerRoot = path.join(root, 'consumer');
130134
const projectRoot = path.join(root, 'project');
@@ -229,6 +233,7 @@ test('installed package exposes Node APIs and packaged companion tunnel entrypoi
229233
});
230234
let metroPort = 0;
231235
try {
236+
ensureBuiltPackage();
232237
const tarballPath = packInstalledPackage(root);
233238
installedPackageRoot = extractInstalledPackage(tarballPath, consumerRoot);
234239
linkRuntimeDependencies(installedPackageRoot, consumerRoot);

0 commit comments

Comments
 (0)