Skip to content

Commit 86c0643

Browse files
committed
chore(gates): remove inactive workflow routing assertions
1 parent 58cb5a0 commit 86c0643

5 files changed

Lines changed: 1 addition & 214 deletions

File tree

‎scripts/gate/audit.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,21 @@ import {
66
MANUAL_ONLY_OWNERS,
77
type ManualOnlyOwner,
88
REPORTING_SCRIPTS,
9-
ROUTED_LANES,
10-
type RoutedLane,
119
UNPROVABLE_OWNERS,
1210
} from './declarations.ts';
1311
import { categories, checkUnits, covered, scriptUnits, type Model } from './model.ts';
14-
import { routing } from './routing.ts';
1512

1613
export type Failure = { readonly assertion: string; readonly message: string };
1714

1815
/** The hand-written half of the manifest, injectable so its own removal can be tested. */
1916
export type GateDeclarations = {
2017
readonly manualOnly: Readonly<Record<string, ManualOnlyOwner>>;
2118
readonly unprovable: Readonly<Record<string, string>>;
22-
readonly routed?: readonly RoutedLane[];
2319
};
2420

2521
const DECLARED: GateDeclarations = {
2622
manualOnly: MANUAL_ONLY_OWNERS,
2723
unprovable: UNPROVABLE_OWNERS,
28-
routed: ROUTED_LANES,
2924
};
3025

3126
const HEADINGS: Readonly<Record<string, string>> = {
@@ -34,7 +29,6 @@ const HEADINGS: Readonly<Record<string, string>> = {
3429
gate: 'Gate ids that name no registered check',
3530
surface: 'Execution surfaces the manifest does not model',
3631
'path-coverage': 'Paths whose selected checks no triggered lane runs',
37-
routing: 'Routed lanes whose paths-ignore disagrees with the selector',
3832
registered: 'Suites and projects no registered check covers',
3933
};
4034

@@ -246,7 +240,6 @@ export function audit(model: Model, declarations: GateDeclarations = DECLARED):
246240
...gateIds(model),
247241
...laneSurfaces(model),
248242
...pathCoverage(model, declarations),
249-
...routing(model, declarations.routed ?? []),
250243
...unregisteredSuites(model),
251244
...orphanProjects(model),
252245
];

‎scripts/gate/declarations.ts‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -72,21 +72,3 @@ export const MANUAL_ONLY_OWNERS: Readonly<Record<string, ManualOnlyOwner>> = {
7272
].join(' '),
7373
},
7474
};
75-
76-
/**
77-
* A `pull_request` lane whose `paths-ignore` list is routing, not hygiene (#1781 A9-2): the
78-
* list is asserted against the affected selector over every tracked path, both ways. A path
79-
* the selector fails open on, or routes to one of the lane's declared gates or to `sampled`
80-
* (checks the lane runs a slice of through raw shell, invisible to the loader), must start the
81-
* lane; a path the selector places on another family's device-lane surface, or classifies as
82-
* a unit test, must not. GitHub evaluates the list before a runner is allocated, so the
83-
* decision costs no macOS time and adds no job to the critical path.
84-
*/
85-
export type RoutedLane = {
86-
/** Lane label, exactly as the loader builds it: `<workflow name> / <job name>`. */
87-
readonly lane: string;
88-
/** Checks the lane samples without declaring, in addition to its run-gate declarations. */
89-
readonly sampled: readonly string[];
90-
};
91-
92-
export const ROUTED_LANES: readonly RoutedLane[] = [];

‎scripts/gate/routing.test.ts‎

Lines changed: 0 additions & 77 deletions
This file was deleted.

‎scripts/gate/routing.ts‎

Lines changed: 0 additions & 110 deletions
This file was deleted.

‎scripts/gate/workflows.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ export type Lane = {
2222
readonly gates: readonly CheckId[];
2323
/**
2424
* Repo-relative files of the local composite actions this job's steps use, transitively,
25-
* plus the workflow file itself: the lane's own machinery. Editing one of these changes what
26-
* the lane does, so the lane cannot claim to be unaffected by it (`scripts/gate/routing.ts`).
25+
* plus the workflow file itself.
2726
*/
2827
readonly uses: readonly string[];
2928
readonly verbatim: readonly string[];

0 commit comments

Comments
 (0)