Repository navigation
Commit 85127f0
committed
fix(interaction): bounded off-screen recovery hint — a large scroll overshoots (#1366 review)
Live evidence exposed that the hint over-promised: it advertised `scroll
<direction>` -> retry-selector as the terminating recovery, but on the
motivating checkout form a plain `scroll` (iOS fling momentum) repeatedly
overshoots the narrow pressable band and the loop never terminates — even
bounded `scroll --pixels 200` oscillates up/down. A momentum-free `gesture pan`
in small steps lands the target (verified: 3–4 attempts -> Tapped "Cash").
Revise the hint to prescribe BOUNDED movement in the named direction, retrying
the same selector after each step, and to name the overshoot failure mode and
the reliable `gesture pan` fallback. Direction + selector-first steering are
unchanged. `scrollRevealClause` drops the "to bring it on-screen" over-promise.
Tests assert the bounded-recovery guidance (small steps / gesture pan) on both a
selector and a ref off-screen path so it can't silently regress.1 parent 503ef6f commit 85127f0
3 files changed
Lines changed: 21 additions & 12 deletions
File tree
- src
- commands/interaction/runtime
- daemon/handlers/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
171 | 175 | | |
172 | 176 | | |
173 | 177 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
700 | 700 | | |
701 | 701 | | |
702 | 702 | | |
703 | | - | |
704 | | - | |
705 | | - | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
706 | 708 | | |
707 | | - | |
| 709 | + | |
708 | 710 | | |
709 | 711 | | |
710 | 712 | | |
| |||
721 | 723 | | |
722 | 724 | | |
723 | 725 | | |
724 | | - | |
| 726 | + | |
725 | 727 | | |
726 | 728 | | |
727 | 729 | | |
728 | 730 | | |
729 | | - | |
730 | | - | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
731 | 735 | | |
732 | | - | |
733 | | - | |
734 | | - | |
| 736 | + | |
735 | 737 | | |
736 | 738 | | |
737 | 739 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2593 | 2593 | | |
2594 | 2594 | | |
2595 | 2595 | | |
2596 | | - | |
2597 | | - | |
| 2596 | + | |
| 2597 | + | |
| 2598 | + | |
2598 | 2599 | | |
2599 | 2600 | | |
| 2601 | + | |
| 2602 | + | |
2600 | 2603 | | |
2601 | 2604 | | |
2602 | 2605 | | |
| |||
0 commit comments