|
| 1 | +import assert from 'node:assert/strict'; |
| 2 | +import { describe, test } from 'vitest'; |
| 3 | +import { AppError } from '@agent-device/kernel/errors'; |
| 4 | +import { |
| 5 | + buildRunnerResponseError, |
| 6 | + decodeRunnerResponseBody, |
| 7 | + isRunnerResponseOk, |
| 8 | + readRunnerResponseData, |
| 9 | +} from '../runner-response.ts'; |
| 10 | + |
| 11 | +// A body cut off mid-write, the shape a runner that died while answering leaves behind. |
| 12 | +const TRUNCATED_BODY = '{"ok":true,"data":{"nodes":[{"label":"Sign In"'; |
| 13 | + |
| 14 | +describe('decodeRunnerResponseBody', () => { |
| 15 | + test('decodes the runner envelope', () => { |
| 16 | + assert.deepEqual(decodeRunnerResponseBody('{"ok":true,"data":{"tapped":true}}'), { |
| 17 | + ok: true, |
| 18 | + data: { tapped: true }, |
| 19 | + }); |
| 20 | + }); |
| 21 | + |
| 22 | + test('rejects a truncated body instead of reading a reply out of it', () => { |
| 23 | + assert.throws( |
| 24 | + () => decodeRunnerResponseBody(TRUNCATED_BODY), |
| 25 | + (error: unknown) => |
| 26 | + error instanceof AppError && |
| 27 | + error.code === 'COMMAND_FAILED' && |
| 28 | + error.message === 'Invalid runner response' && |
| 29 | + error.details?.text === TRUNCATED_BODY, |
| 30 | + ); |
| 31 | + }); |
| 32 | + |
| 33 | + test('never reads a JSON body that is not an envelope as an answer', () => { |
| 34 | + for (const body of ['null', '42', '"ok"']) { |
| 35 | + assert.equal(isRunnerResponseOk(decodeRunnerResponseBody(body)), false, body); |
| 36 | + } |
| 37 | + }); |
| 38 | + |
| 39 | + test('carries a bare-array body through unread rather than inventing an envelope', () => { |
| 40 | + const payload = decodeRunnerResponseBody('[]'); |
| 41 | + assert.equal(isRunnerResponseOk(payload), false); |
| 42 | + assert.deepEqual(readRunnerResponseData(payload), {}); |
| 43 | + }); |
| 44 | +}); |
| 45 | + |
| 46 | +describe('isRunnerResponseOk', () => { |
| 47 | + test('accepts only the boolean true the runner sends', () => { |
| 48 | + assert.equal(isRunnerResponseOk({ ok: true }), true); |
| 49 | + assert.equal(isRunnerResponseOk({ ok: false }), false); |
| 50 | + assert.equal(isRunnerResponseOk({}), false); |
| 51 | + // Stringly-typed truthiness would let a proxy or a wedged socket answer for the runner. |
| 52 | + assert.equal(isRunnerResponseOk({ ok: 'true' }), false); |
| 53 | + assert.equal(isRunnerResponseOk({ ok: 1 }), false); |
| 54 | + }); |
| 55 | +}); |
| 56 | + |
| 57 | +describe('readRunnerResponseData', () => { |
| 58 | + test('reads only an object data payload', () => { |
| 59 | + assert.deepEqual(readRunnerResponseData({ ok: true, data: { tapped: true } }), { |
| 60 | + tapped: true, |
| 61 | + }); |
| 62 | + assert.deepEqual(readRunnerResponseData({ ok: true }), {}); |
| 63 | + assert.deepEqual(readRunnerResponseData({ ok: true, data: null }), {}); |
| 64 | + assert.deepEqual(readRunnerResponseData({ ok: true, data: [] }), {}); |
| 65 | + assert.deepEqual(readRunnerResponseData({ ok: true, data: 'tapped' }), {}); |
| 66 | + }); |
| 67 | +}); |
| 68 | + |
| 69 | +describe('buildRunnerResponseError', () => { |
| 70 | + test('carries the payload, the runner hint, and the classified code', () => { |
| 71 | + const error = buildRunnerResponseError( |
| 72 | + { |
| 73 | + ok: false, |
| 74 | + error: { |
| 75 | + code: 'RUNNER_BUSY', |
| 76 | + message: 'Main thread is busy', |
| 77 | + hint: 'Retry after it drains', |
| 78 | + }, |
| 79 | + }, |
| 80 | + '/tmp/runner.log', |
| 81 | + ); |
| 82 | + |
| 83 | + assert.ok(error instanceof AppError); |
| 84 | + assert.equal(error.code, 'COMMAND_FAILED'); |
| 85 | + assert.equal(error.message, 'Main thread is busy'); |
| 86 | + assert.equal(error.details?.hint, 'Retry after it drains'); |
| 87 | + assert.equal(error.details?.logPath, '/tmp/runner.log'); |
| 88 | + assert.equal(error.details?.retriable, true); |
| 89 | + assert.deepEqual((error.details as { runner?: unknown }).runner, { |
| 90 | + ok: false, |
| 91 | + error: { code: 'RUNNER_BUSY', message: 'Main thread is busy', hint: 'Retry after it drains' }, |
| 92 | + }); |
| 93 | + }); |
| 94 | + |
| 95 | + test('keeps a missing runner message as a generic runner error', () => { |
| 96 | + const error = buildRunnerResponseError({ ok: false, error: {} }); |
| 97 | + assert.equal(error.message, 'Runner error'); |
| 98 | + assert.equal(error.details?.hint, undefined); |
| 99 | + }); |
| 100 | +}); |
0 commit comments