|
| 1 | +import assert from 'node:assert/strict'; |
| 2 | +import { beforeEach, test, vi } from 'vitest'; |
| 3 | +import type { CommandExecutorOverride } from './exec.ts'; |
| 4 | + |
| 5 | +const { mockRunCmdSync } = vi.hoisted(() => ({ mockRunCmdSync: vi.fn() })); |
| 6 | + |
| 7 | +vi.mock('./exec.ts', async (importOriginal) => ({ |
| 8 | + ...(await importOriginal<typeof import('./exec.ts')>()), |
| 9 | + runCmdSync: mockRunCmdSync, |
| 10 | +})); |
| 11 | + |
| 12 | +let withCommandExecutorOverride: typeof import('./exec.ts').withCommandExecutorOverride; |
| 13 | +let readHostCpuArch: typeof import('./host-process.ts').readHostCpuArch; |
| 14 | +let readHostCpuArchSync: typeof import('./host-process.ts').readHostCpuArchSync; |
| 15 | +let resolveHostCpuArch: typeof import('./host-process.ts').resolveHostCpuArch; |
| 16 | + |
| 17 | +// The host CPU arch is resolved once per module instance, so each test gets a fresh one. |
| 18 | +beforeEach(async () => { |
| 19 | + mockRunCmdSync.mockReset(); |
| 20 | + vi.resetModules(); |
| 21 | + ({ withCommandExecutorOverride } = await import('./exec.ts')); |
| 22 | + ({ readHostCpuArch, readHostCpuArchSync, resolveHostCpuArch } = |
| 23 | + await import('./host-process.ts')); |
| 24 | +}); |
| 25 | + |
| 26 | +function sysctlAnswering(result: { stdout?: string; exitCode?: number } | Error) { |
| 27 | + const calls: string[][] = []; |
| 28 | + const override: CommandExecutorOverride = async (command, args) => { |
| 29 | + calls.push([command, ...args]); |
| 30 | + if (result instanceof Error) throw result; |
| 31 | + return { stdout: result.stdout ?? '', stderr: '', exitCode: result.exitCode ?? 0 }; |
| 32 | + }; |
| 33 | + return { calls, override }; |
| 34 | +} |
| 35 | + |
| 36 | +test('an Apple silicon Mac reports arm64 even when Node runs as x64 under Rosetta', async () => { |
| 37 | + const sysctl = sysctlAnswering({ stdout: '1\n' }); |
| 38 | + const arch = await withCommandExecutorOverride(sysctl.override, () => |
| 39 | + resolveHostCpuArch('darwin', 'x64'), |
| 40 | + ); |
| 41 | + assert.equal(arch, 'arm64'); |
| 42 | + assert.deepEqual(sysctl.calls, [['/usr/sbin/sysctl', '-n', 'hw.optional.arm64']]); |
| 43 | +}); |
| 44 | + |
| 45 | +test('a Mac without the arm64 sysctl key falls back to the Node arch in Apple naming', async () => { |
| 46 | + for (const answer of [ |
| 47 | + { stdout: '', exitCode: 1 }, |
| 48 | + { stdout: '0\n' }, |
| 49 | + new Error('spawn /usr/sbin/sysctl ENOENT'), |
| 50 | + ]) { |
| 51 | + const sysctl = sysctlAnswering(answer); |
| 52 | + const arch = await withCommandExecutorOverride(sysctl.override, () => |
| 53 | + resolveHostCpuArch('darwin', 'x64'), |
| 54 | + ); |
| 55 | + assert.equal(arch, 'x86_64'); |
| 56 | + } |
| 57 | +}); |
| 58 | + |
| 59 | +test('other platforms report the Node arch without running sysctl', async () => { |
| 60 | + const sysctl = sysctlAnswering({ stdout: '1\n' }); |
| 61 | + await withCommandExecutorOverride(sysctl.override, async () => { |
| 62 | + assert.equal(await resolveHostCpuArch('linux', 'x64'), 'x86_64'); |
| 63 | + assert.equal(await resolveHostCpuArch('linux', 'arm64'), 'arm64'); |
| 64 | + assert.equal(await resolveHostCpuArch('linux', 'ppc64'), 'ppc64'); |
| 65 | + }); |
| 66 | + assert.deepEqual(sysctl.calls, []); |
| 67 | +}); |
| 68 | + |
| 69 | +async function asDarwinX64Process(run: () => Promise<void>): Promise<void> { |
| 70 | + const platform = Object.getOwnPropertyDescriptor(process, 'platform')!; |
| 71 | + const arch = Object.getOwnPropertyDescriptor(process, 'arch')!; |
| 72 | + Object.defineProperty(process, 'platform', { ...platform, value: 'darwin' }); |
| 73 | + Object.defineProperty(process, 'arch', { ...arch, value: 'x64' }); |
| 74 | + try { |
| 75 | + await run(); |
| 76 | + } finally { |
| 77 | + Object.defineProperty(process, 'platform', platform); |
| 78 | + Object.defineProperty(process, 'arch', arch); |
| 79 | + } |
| 80 | +} |
| 81 | + |
| 82 | +test('the per-process value a Rosetta-translated process resolves is the one sync callers read', async () => { |
| 83 | + await asDarwinX64Process(async () => { |
| 84 | + const sysctl = sysctlAnswering({ stdout: '1\n' }); |
| 85 | + const resolved = await withCommandExecutorOverride(sysctl.override, () => readHostCpuArch()); |
| 86 | + assert.equal(resolved, 'arm64'); |
| 87 | + assert.equal(readHostCpuArchSync(), 'arm64'); |
| 88 | + assert.equal(sysctl.calls.length, 1); |
| 89 | + assert.equal(mockRunCmdSync.mock.calls.length, 0); |
| 90 | + }); |
| 91 | +}); |
| 92 | + |
| 93 | +test('a Rosetta-translated process resolves arm64 through the sync path first, and async callers share it', async () => { |
| 94 | + await asDarwinX64Process(async () => { |
| 95 | + mockRunCmdSync.mockReturnValue({ stdout: '1\n', stderr: '', exitCode: 0 }); |
| 96 | + assert.equal(readHostCpuArchSync(), 'arm64'); |
| 97 | + assert.deepEqual( |
| 98 | + mockRunCmdSync.mock.calls.map(([command, args]) => [command, ...args]), |
| 99 | + [['/usr/sbin/sysctl', '-n', 'hw.optional.arm64']], |
| 100 | + ); |
| 101 | + |
| 102 | + const sysctl = sysctlAnswering({ stdout: '0\n' }); |
| 103 | + const resolved = await withCommandExecutorOverride(sysctl.override, () => readHostCpuArch()); |
| 104 | + assert.equal(resolved, 'arm64'); |
| 105 | + assert.deepEqual(sysctl.calls, []); |
| 106 | + }); |
| 107 | +}); |
| 108 | + |
| 109 | +test('a sync read on an Intel Mac reports x86_64', async () => { |
| 110 | + await asDarwinX64Process(async () => { |
| 111 | + mockRunCmdSync.mockReturnValue({ stdout: '', stderr: '', exitCode: 1 }); |
| 112 | + assert.equal(readHostCpuArchSync(), 'x86_64'); |
| 113 | + }); |
| 114 | +}); |
0 commit comments