You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 80bf831
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ios-runner): bound synthesized delivery by the main-thread watchdog and pin the pace the app sees
A 358-character fill through the daemon was abandoned by the runner's
30 s main-thread watchdog with the burst still typing. The delivery
ceiling was a free-standing 30 s sized against the 45 s transport budget,
while the whole command runs under mainThreadExecutionTimeout. The
ceiling is now derived from that watchdog minus a focus allowance and the
commit wait's ceiling (18 s), so the admitted text fits with the longest
commit wait: 214 characters undelayed, 57 at --delay-ms 80.
The app-owned-value lane test accepted either outcome and stayed green at
60 characters per second. It now asserts the spacing the fixture app
receives: a burst's characters average at least one acknowledge window
apart. That is red at 60 (11 edits in about 110 ms) and green at 12
(about 780 ms). A strict "the app keeps up" assertion is not possible:
at a 40 ms window, 12 characters per second still lost one character in
13 of 20 bursts, because XCTest spaces the characters unevenly. The
comments that claimed survival are narrowed to match.
The call overhead and the --delay-ms 80 recovery delay move into
TextEntryTiming beside the other text-entry timings, and both hints read
the recovery delay from there.
Copy file name to clipboardExpand all lines: apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+TextEntry.swift
+28-16Lines changed: 28 additions & 16 deletions
Original file line number
Diff line number
Diff line change
@@ -30,9 +30,13 @@ extension RunnerTests {
30
30
case.synthesisUnavailable:
31
31
return"Show the software keyboard, then retry type."
32
32
case.commitNotObserved:
33
-
return"The field may hold none, part, or all of the text. Run snapshot -i and inspect the field: if it already matches, continue; otherwise retry fill with the full text quoted and --delay-ms 80. Do not use type, which appends to whatever committed."
33
+
return"The field may hold none, part, or all of the text. Run snapshot -i and inspect the field: if it already matches, continue; otherwise retry fill with the full text quoted and --delay-ms \(TextEntryTiming.recoveryDelayMilliseconds). Do not use type, which appends to whatever committed."
34
34
case.synthesisBudgetExceeded:
35
-
return"Fill at most \(SynthesizedDeliveryBudget.maxTextLength(delaySeconds:0)) characters at a time without --delay-ms and append the rest with separate type commands, keeping each command inside that budget. --delay-ms lowers the budget, because every character then pays its own synthesize call and the delay: \(SynthesizedDeliveryBudget.maxTextLength(delaySeconds:0.08)) characters at --delay-ms 80. A longer timeout does not help: this route is chosen when the accessibility channel is already degraded, and the pace is what makes the text long."
return"Fill at most \(SynthesizedDeliveryBudget.maxTextLength(delaySeconds:0)) characters at a time without --delay-ms and append the rest with separate type commands, keeping each command inside that budget. --delay-ms lowers the budget, because every character then pays its own synthesize call and the delay: \(recoveryBudget) characters at --delay-ms \(recoveryDelay). A longer timeout does not help: this route is chosen when the accessibility channel is already degraded, and the pace is what makes the text long."
36
40
}
37
41
}
38
42
}
@@ -55,22 +59,30 @@ extension RunnerTests {
55
59
/// condemned at exactly the same instant it always was (see `SynthesizedCommitDeadline`).
0 commit comments