You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7e741b7
Browse filesBrowse the repository at this point in the historyBrowse files
test(ios): size the alert command's deadline to the host's own reads (#2708)
* test(ios): size the alert command's deadline to the host's own reads
The three replacement-alert fixtures give the alert command 10000 ms, and that budget
only means something in units of what one accessibility read costs the host: the
deadline starts at dispatch, and `resolveAlert` spends 24 reads before it chooses a
button. On a host that answers a read in 1.7 s the deadline therefore expires
mid-resolution and the command reports `ALERT_DEADLINE_EXCEEDED` without ever
synthesizing the tap. That is what the nightly's red runs did: 31.2 s, 30.6 s and
40.4 s of reads against the 6.2 s a green run spends.
The fixtures now time a read once the alert is up and derive `timeoutMs` from it,
floored at the production default and capped at this lane's slowest existing test, so
a quiet host asks for exactly what it asked for before and a contended one gets a
budget covering the reads it is actually doing. Pinning the derived budget to 250 ms
reproduces a red nightly byte for byte, `First actions: 0; replacement actions: 0`
included.
Refs #2546
* chore(gates): run the alert deadline sizing test on every PR
The invariant it pins lives in an iOS-only file, so the nightly was the first lane to
see it. Its six sibling fixtures are already in the ios.yml list.
0 commit comments