Skip to content

Commit 7c9bddd

Browse files
thymikeeclaude
andcommitted
chore(ci): drop stale shared-header packaging and nightly narrative
The size-report pack-stub check rebuilt the same expected-stub paths from the manifest three times; build the set once and derive both directions from it. The dist/apple/snapshot-bridge legacy entry only ever existed on unreleased branch builds of #3918, so the packager no longer removes it. The nightly iPad-leg comments described a probe log line the runner no longer prints; correct them to name the assertions. Delete the packaged- layout fingerprint duplicate: production has no checkout/package branch for the shared header, and the checkout-layout test detects its removal. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 581357b commit 7c9bddd

4 files changed

Lines changed: 12 additions & 35 deletions

File tree

‎.github/workflows/xctest-nightly.yml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131
# The full suite runs on an iPhone, where the sole-screen rule is decided by the idiom
3232
# alone. The iPad leg boots an iPad and runs only the sole-screen tests: the iPad half
3333
# of the rule — the route opens only while the in-process full-screen evidence proves
34-
# the app fills its screen — can execute nowhere else, and the evidence line that probe
35-
# prints is what turns a revert to idiom-only routing red instead of silently green.
34+
# the app fills its screen — can execute nowhere else, so only its assertions can turn
35+
# a revert to idiom-only routing red instead of silently green.
3636
# `name-prefix` is what each leg asserts the booted simulator's name starts with: the
3737
# boot action falls back to any simulator when the preferred name is missing, so a
3838
# renamed or absent device model must fail the leg that depends on its idiom.
@@ -92,8 +92,9 @@ jobs:
9292

9393
# The boot action falls back to any simulator when the preferred name is missing, so each
9494
# leg proves it booted the family it claims: the full-suite leg's coverage is iPhone-only at
95-
# the idiom, and the iPad leg's evidence line can only come from an iPad. A renamed or
96-
# removed device model on the image fails here instead of quietly testing the wrong idiom.
95+
# the idiom, and the iPad leg's sole-screen tests can only prove the rule on an iPad. A
96+
# renamed or removed device model on the image fails here instead of quietly testing the
97+
# wrong idiom.
9798
- name: Assert the booted simulator's family
9899
run: |
99100
set -euo pipefail
@@ -150,7 +151,7 @@ jobs:
150151
151152
# The iPad leg runs a named selection: the smallest set that can execute the off-phone half of
152153
# the sole-screen rule — the admission boundary itself, one hostile-tree command that must
153-
# reach synthesis, and `back`'s route witness while the fallback's inset source is changing.
154+
# reach synthesis, and `back`'s route witness.
154155
# Geometry and error cases live in the host-runnable evidence matrix instead. `xcodebuild`
155156
# exits 0 when a selection matches nothing, so the reporter below asserts the executed count
156157
# against this lane's reach (`XCTEST_LANE=nightly-ipad`, derived by check:xctest-selection).

‎packages/platform-apple/src/runner/__tests__/runner-source.test.ts‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -71,24 +71,6 @@ test('computeRunnerSourceFingerprint covers the shared foreground geometry heade
7171
assert.notEqual(computeRunnerSourceFingerprint(root), before);
7272
});
7373

74-
test('computeRunnerSourceFingerprint covers the shared header when the runner comes from the packaged layout', () => {
75-
const root = makeTempRoot();
76-
fs.mkdirSync(
77-
path.join(root, 'dist', 'apple', 'runner', 'AgentDeviceRunner', 'AgentDeviceRunner.xcodeproj'),
78-
{ recursive: true },
79-
);
80-
// An installed package keeps the header at the same root-relative path the checkout uses; only
81-
// the runner source moves under dist/.
82-
const header = path.join(root, 'apple', 'snapshot-bridge', 'ForegroundApplicationGeometry.h');
83-
fs.mkdirSync(path.dirname(header), { recursive: true });
84-
fs.writeFileSync(header, '#pragma once\n');
85-
86-
const before = computeRunnerSourceFingerprint(root);
87-
fs.writeFileSync(header, '#pragma once\n// changed\n');
88-
89-
assert.notEqual(computeRunnerSourceFingerprint(root), before);
90-
});
91-
9274
test('computeRunnerSourceFingerprint covers the shared snapshot presentation sources', () => {
9375
const root = makeTempRoot();
9476
fs.mkdirSync(path.join(root, 'apple', 'runner', 'AgentDeviceRunner'), { recursive: true });

‎scripts/package-apple-runner-source.mjs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ const SNAPSHOT_PRESENTATION_DEVELOPMENT_DIR_NAMES = new Set([
3030
const LEGACY_OUTPUT_DIRS = [
3131
path.join('dist', 'apple-runner'),
3232
path.join('dist', 'apple', 'apple-runner'),
33-
// A short-lived build mirrored the shared header beside the packaged runner; the UITests target
34-
// finds it through HEADER_SEARCH_PATHS now, so a leftover copy must not double-ship.
35-
path.join('dist', 'apple', 'snapshot-bridge'),
3633
];
3734
const SKIPPED_DIR_NAMES = new Set(['.build', '.swiftpm', 'UnitTests', 'xcuserdata']);
3835
const SKIPPED_ROOT_FILES = new Set(['README.md', 'RUNNER_PROTOCOL.md']);

‎scripts/size-report-package.mjs‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -131,24 +131,21 @@ export function assertPublishPackageContents(entries, options = {}) {
131131
path.join(options.repoRoot ?? process.cwd(), 'apple/macos-helper/Package.swift'),
132132
'utf8',
133133
);
134-
const testTargets = readMacosHelperTestTargets(manifestSource);
135-
const missingStubs = testTargets.filter(
136-
(target) => !paths.includes(`apple/macos-helper/Tests/${target}/PackStub.swift`),
134+
const expectedStubs = new Set(
135+
readMacosHelperTestTargets(manifestSource).map(
136+
(target) => `apple/macos-helper/Tests/${target}/PackStub.swift`,
137+
),
137138
);
139+
const missingStubs = [...expectedStubs].filter((stubPath) => !paths.includes(stubPath));
138140
if (missingStubs.length > 0) {
139141
throw new Error(
140-
`npm pack is missing macOS helper test-target pack stubs: ${missingStubs
141-
.map((target) => `apple/macos-helper/Tests/${target}/PackStub.swift`)
142-
.join(', ')}`,
142+
`npm pack is missing macOS helper test-target pack stubs: ${missingStubs.join(', ')}`,
143143
);
144144
}
145145
// The other direction: a declared stub whose target left the manifest stays exempt from the
146146
// path guard above, so compare against the manifest set here. A target removed or renamed
147147
// without retiring its package.json `files` entry and its DOCUMENTED_PACK_STUBS declaration
148148
// would otherwise ship a dead stub forever.
149-
const expectedStubs = new Set(
150-
testTargets.map((target) => `apple/macos-helper/Tests/${target}/PackStub.swift`),
151-
);
152149
const staleStubs = [...documentedStubPaths].filter(
153150
(stubPath) => paths.includes(stubPath) && !expectedStubs.has(stubPath),
154151
);

0 commit comments

Comments
 (0)