Skip to content

Commit 7af51db

Browse files
committed
chore(gates): remove ambient SDK process entry waivers
1 parent 47d365c commit 7af51db

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎scripts/layering/process-globals-policy.test.ts‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ test('entry declarations permit process reads but do not permit ambient command-
6161
'packages/capture-kit/src/png-worker.ts',
6262
'packages/maestro/src/daemon-port/run-script-http-child.ts',
6363
'packages/react-native/src/companion/client-companion-tunnel-worker.ts',
64-
'src/sdk/host.ts',
65-
'packages/host-kit/src/local-artifact-adapter.ts',
6664
]) {
6765
assert.deepEqual(check('process.env; process.on("SIGINT", stop);', file), [], file);
6866
assert.equal(check('commandHostEnvironment();', file).length, 1, file);
@@ -124,11 +122,16 @@ test('bare process values are captures in calls, aliases, spreads, returns and c
124122
"import * as p from 'node:process'; captureHostEnvironment(p.default);",
125123
]) {
126124
assert.equal(check(source).length, 1, source);
127-
assert.deepEqual(check(source, 'src/sdk/host.ts'), [], source);
125+
assert.equal(check(source, 'src/sdk/host.ts').length, 1, source);
126+
assert.equal(
127+
check(source, 'packages/host-kit/src/local-artifact-adapter.ts').length,
128+
1,
129+
source,
130+
);
128131
}
129132
});
130133

131-
test('SDK adapters capture their default host only through the shared entry', () => {
134+
test('SDK adapters cannot capture a process host', () => {
132135
for (const file of [
133136
'src/sdk/android-adb.ts',
134137
'src/sdk/artifacts.ts',

‎scripts/layering/process-globals-policy.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ const PROCESS_ENTRIES = new Set([
1717
'packages/react-native/src/companion/client-companion-tunnel-worker.ts',
1818
'packages/maestro/src/daemon-port/run-script-child.ts',
1919
'packages/maestro/src/daemon-port/run-script-http-child.ts',
20-
// Released SDK defaults; #3759 removes these captures in 0.22.
21-
'packages/host-kit/src/local-artifact-adapter.ts',
22-
'src/sdk/host.ts',
2320
'src/mcp/command-tools.ts',
2421
'packages/daemon-client/src/index.ts',
2522
'packages/daemon-client/src/daemon-client-ensure.ts',

0 commit comments

Comments
 (0)