Repository navigation
Commit 7997dc2
feat(harmonyos): report the keyboard band in snapshot responses (#4285)
* feat(harmonyos): measure the software keyboard band into snapshot's keyboard fact
The ArkUI layout dump never shows the input method window, so a harmony
snapshot left the keyboard band unmeasured: the tap guard's docked-tree
derivation had no anchor to read, and a tap behind the keyboard failed
open while the touch landed on a key. The window manager's public dump
(hidumper -s WindowManagerService -a -a) lists the SCBKeyboardPanel
window with its rect, so the producer now reads the band there and
publishes it beside the tree.
A positive rect with a non-negative z-order is the measured band; a
zero rect is the hidden keyboard, published as visibility-only. A probe
that fails, a table without the panel, or an unreadable rect publishes
unmeasurable, which leaves the guard's tree derivation and its fail-open
verdict exactly as they were. Gesture viewport reads skip the probe so
gesture planning keeps its old cost.
The keyboard status command stays unavailable; this fact rides snapshot
only, where the capture that produced the tree measured the band too.
Co-Authored-By: Claude Code <[email protected]>
* docs(evidence): record the keyboard band through a raise and dismiss
Co-Authored-By: Claude Code <[email protected]>
* fix(harmonyos): keep the keyboard band off a display-spanning panel rect
The WindowManagerService table reports SCBKeyboardPanel (and the IME's own
softKeyboard1 window) with the full display rect whether the keyboard shows
or hides; only the z-order column moves. Publishing that rect as a visible
band made the tap guard read every on-screen point as keyboard-covered,
refusing ref and selector presses above the keyboard. A panel rect the
table cannot prove smaller than the display now publishes visibility-only,
which leaves the guard on its tree derivation and fail-open; a rect the
table proves to be a partial strip still publishes the frame. Fixtures
carry the real JDY-AL50 rows captured with the IME raised and dismissed.
Co-Authored-By: Claude Code <[email protected]>
* docs(evidence): re-run the keyboard band at the rebased head with the real rows
Replaces the invalidated run: the window table's real rows quoted verbatim
(up and hidden), the visibility-only contract live through a raise and a
dismiss, the guard regressions retired (a ref above the band succeeds, an
in-band coordinate press dispatches), probe cost measured, the model string
corrected to JUY-AL50, and the landing-order section the review asked for.
The keys-only screenshot crop keeps the app's search page out of the repo.
Co-Authored-By: Claude Code <[email protected]>
* docs(evidence): state the 0.9 display-area share threshold for band publication
cubic review P2: the evidence said 'rect smaller than the display' but the
producer keys on DISPLAY_SPANNING_RECT_SHARE = 0.9 — a band publishes only
under that share; at or above it the panel is the full-surface container.
Say the threshold so the document matches the shipped contract.
* refactor(harmonyos): publish keyboard visibility only, never a band frame
The window table proves no band: on the measured build the panel row reports the
whole display whether the keyboard shows or hides, so the rect branch of the
producer was dead code on every build it could observe — and a future build with
a partial container would have published that container as the key plane, which
the tap guard trusts, reviving the false refusals #4285 set out to remove.
The producer now reads the panel row's z-order alone: visible when any panel
carries a non-negative z-order, hidden when none does. A readable-z-only guard
answers unmeasurable (the rect column no longer backs any verdict), and panel
rows that disagree across displays answer unmeasurable rather than pick a
winner, since the probe has no display scope. The 0.9 display-share threshold,
the largest-rect display derivation, and the multi-display scan are deleted —
the guard cannot be handed a frame this table cannot prove.
* docs(evidence): re-run the keyboard band at the z-order-only head
Same device, same choreography, same facts: visibility-only false on the
settings home, visibility-only true with the IME raised, a bare in-band
coordinate press dispatching under the fail-open guard, and one Back returning
the fact to hidden. The rect-share rule sections are rewritten for the
z-order-only producer; the landscape note no longer derives from rect geometry.
---------
Co-authored-by: Claude Code <[email protected]>1 parent 5ec56d0 commit 7997dc2
6 files changed
Lines changed: 492 additions & 3 deletions
File tree
- docs/evidence
- packages
- command-surface/src/capture
- platform-harmonyos/src
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
0 commit comments