Skip to content

Commit 7770552

Browse files
committed
docs(snapshot): clarify Appium measurement guarantees
1 parent 2467128 commit 7770552

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/provider-webdriver/src/webdriver-interactor.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,10 @@ class WebDriverInteractor implements Interactor {
352352
};
353353
}
354354

355+
/**
356+
* W3C window rect has no server-side deadline. The transport bound limits client
357+
* waiting; Appium can keep its command lock until the downstream read finishes.
358+
*/
355359
private async readAndroidSnapshotViewport(signal?: AbortSignal) {
356360
try {
357361
const rect = await this.client.windowRect({

‎website/docs/docs/snapshots.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ With Android Appium, `snapshot --json` includes `viewport: { "width": …, "heig
117117
driver can measure the display. These dimensions use the same coordinates as node rectangles and
118118
are refreshed for each capture, including after rotation. Opening the keyboard can shrink the app's
119119
content without shrinking the display viewport. An empty or sparse tree can still have a viewport;
120-
when the display changes during capture or either measurement is unavailable, `viewport` is absent.
120+
when the measurements disagree or either measurement is unavailable, `viewport` is absent.
121121

122122
## Structured node fields (`--json`)
123123

0 commit comments

Comments
 (0)