You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 75b414a
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(move): runtime assembly pair into command-runtime (#3294) (#3299)
* refactor(move): move the runtime assembly pair into the command-runtime folder
createAgentDeviceRuntime and the command-surface binding over it are the
in-process runtime assembly #3288 already classifies as command-runtime.
They now live under src/command-runtime/, where topFolder derives that
zone from the folder instead of per-file ROOT_MODULE_ZONES rows. Both
files move as one group: the surface file composes the factory's result,
and neither is importable from the other's consumers separately.
Importers (src/runtime.ts and the daemon runtime modules) re-point.
* docs(adr): record the runtime assembly pair as moved with its PR link
The rows and prose claim only this change's collocation; the
diagnostics-scope wording inherited from #3297 is left untouched.
* chore(gates): drop the moved runtime assembly rows from ROOT_MODULE_ZONES
Both files now live under src/command-runtime/, so topFolder derives
their command-runtime zone from the folder and the per-file rows are
redundant. The drift test proves the declaration matches the tree;
the fallow comment follows the moved factory path.
Copy file name to clipboardExpand all lines: .fallowrc.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -562,7 +562,7 @@
562
562
]
563
563
},
564
564
{
565
-
"comment": "src/runtime.ts keeps its published type surface while its implementation moves to src/runtime-factory.ts (#2540). These two re-exports have no in-repo consumer; they stay so the module's exported shape is unchanged.",
565
+
"comment": "src/runtime.ts keeps its published type surface while its implementation moves to src/command-runtime/runtime-factory.ts (#2540, #3294). These two re-exports have no in-repo consumer; they stay so the module's exported shape is unchanged.",
`request-progress-protocol.ts`) trace to #2559, which relocated the shared contracts **to the
128
129
process root** so the client stops importing `src/daemon/` at all; R78 keeps any client→daemon
@@ -143,8 +144,8 @@ constrain a relocation, they are not independent proof the placement is optimal.
143
144
|`src/provider-credential-fingerprint.ts`| keep | Daemon ⇄ client shared contract from the same #2559 decision as `daemon-policy-file.ts`; #3288 declares its zone beside the provider composition that reads the credentials it fingerprints. |
144
145
|`src/provider-limrun-runtime.ts`| keep | Proposed → provider-limrun, but there is no seam: the class's constructor self-builds the root dependency factory (`src/sdk/limrun-runtime-dependencies.ts`), which is the ADR 0019 composition seam — it loads the root's adb-host binder, core Android interactor, and platform-runtime app-state helpers that the package must not import. Moving the class means moving that composition, which is design, not a move. |
145
146
|`src/request-progress-protocol.ts`| keep | Daemon ⇄ client shared contract from the same #2559 decision — the client reads it statically (`daemon-client-progress.ts`) and the server through `src/daemon/server/`, so only #2559's shared-placement boundary and the wire-compat ledgers pin it; declared `daemon-contracts` by #3288. Contracts was considered and R18 keeps contracts free of envelope validation mechanics. |
146
-
|`src/runtime-command-surface.ts`|move (outstanding, #3294)|Confirmed as an outstanding physical move, not reconsidered. Importers: `src/runtime.ts`(static) and daemon runtime modules; #3288's `command-runtime` assignment classifies it only — #3294 owns the physical move and the `ROOT_MODULE_ZONES` row deletion. |
147
-
|`src/runtime-factory.ts`|move (outstanding, #3294)|Same: statically imported by `src/runtime.ts` and two daemon modules; outstanding physical move tracked by #3294. |
147
+
|`src/runtime-command-surface.ts`|moved → `src/command-runtime/runtime-command-surface.ts` ([#3299](https://github.com/callstack/agent-device/pull/3299))|Physical move landed with `runtime-factory.ts`as one assembly group: the command-surface binding sits beside the factory it composes, under the folder that derives its `command-runtime` zone, so `topFolder` replaces the per-file `ROOT_MODULE_ZONES` row. |
148
+
|`src/runtime-factory.ts`|moved → `src/command-runtime/runtime-factory.ts` ([#3299](https://github.com/callstack/agent-device/pull/3299))|Physical move landed: the runtime assembly now lives under the folder that derives its `command-runtime` zone, with the same row deletion through folder-derived ownership. |
148
149
149
150
### sdk
150
151
@@ -167,10 +168,11 @@ files have no seam (published facade, public-type collision, root dependency fac
167
168
168
169
- Physical root-pass moves under [#3294](https://github.com/callstack/agent-device/issues/3294)
169
170
(child of #3276): `daemon-diagnostics-scope.ts` has moved into `src/daemon-contracts/`
170
-
([#3297](https://github.com/callstack/agent-device/pull/3297)); `runtime-command-surface.ts` and
171
-
`runtime-factory.ts` remain **outstanding** under #3294. The folder derives its zone, replacing
172
-
the moved file's `ROOT_MODULE_ZONES` row; #3288's zone assignment alone was classification, and
173
-
this move completes that file's collocation.
171
+
([#3297](https://github.com/callstack/agent-device/pull/3297)); the runtime assembly pair
172
+
`runtime-command-surface.ts` / `runtime-factory.ts` is collocated in `src/command-runtime/`
173
+
([#3299](https://github.com/callstack/agent-device/pull/3299)). Each folder derives its zone,
174
+
replacing the moved files' `ROOT_MODULE_ZONES` rows; #3288's zone assignments alone were
175
+
classification, and each landed move completes its own file's collocation.
0 commit comments