@@ -4,18 +4,20 @@ Keep reviewed source read-only. Run checks in an isolated checkout if they can m
44
55## Reviewing
66
7- - Read linked dependencies and relevant ADRs. Resolve prerequisite conflicts first. Update or supersede conflicting decisions explicitly.
8- - Trace routing and surface changes through daemon and backend. Helper tests bypassing the router do not prove dispatch.
9- Check affected CLI, Node, daemon, MCP, help, and docs surfaces.
10- - Trace typed errors from producers through normalization, transport, and sibling consumers. Do not replace lost reason codes with text matching.
11- - Classify interaction paths in ` packages/contracts/src/interaction-guarantees.ts ` . Verify each claim against native code.
7+ Review for concrete regressions. Follow callers and siblings as needed to verify changed behavior.
8+ Apply each check only when the change affects its subject. Reopen a resolved concern only when new evidence changes the conclusion.
9+
10+ - Dependencies and ADRs: resolve prerequisite conflicts. Update or supersede conflicting decisions explicitly.
11+ - Routing and surfaces: trace through daemon and backend to affected entrypoints. Helper tests bypassing the router do not prove dispatch.
12+ - Typed errors: follow reasons from producers through normalization, transport, and consumers. Never replace them with text matching.
13+ - Interaction paths: verify ` packages/contracts/src/interaction-guarantees.ts ` claims against native code.
1214 Error-path delegation does not prove success-path parity. Prove both paths reachable before comparing performance.
13- - A platform -family claim covers every backend, including Appium and ADB, or names the covered backends.
14- - Keep snapshot-wide metadata at response level. Append warnings through the shared builder; never replace prior warnings .
15- Check compact defaults, bounded arrays, and artifact paths for large evidence.
16- - Before retaining compatibility, run ` git tag --contains <commit> ` . Unreleased shapes have no external compatibility obligation.
17- - Require each new test to detect a credible production failure. Test doubles must fail at the same seam as production.
18- - Find dead code, redundant guards, casts, narrating comments, and competing owners. Fix the owning rule, not only named sites .
15+ - Platform -family claims: cover every backend, including Appium and ADB, or name the covered backends.
16+ - Response shape: keep snapshot-wide metadata at response level. Append warnings through the shared builder.
17+ Preserve compact defaults, bounded arrays, and artifact paths for large evidence.
18+ - Retained compatibility: run ` git tag --contains <commit> ` . Unreleased shapes have no external compatibility obligation.
19+ - New tests: each must detect a credible production failure. Test doubles must fail at the same seam as production.
20+ - Changed code: flag dead code, redundant guards, casts, narrating comments, and competing owners.
1921
2022Use CI Size evidence. At about 700 net production lines or 3 kB npm growth, require an independent reviewer to assess a smaller design.
2123Also assess any new abstraction, dependency, seam, or ownership rule. Weigh gross churn for moves. Explain justified growth.
@@ -25,4 +27,3 @@ Also assess any new abstraction, dependency, seam, or ownership rule. Weigh gros
2527Report only triggering scenarios: ` file:line ` , severity, what breaks, and the fix.
2628If none, say so. Reject incorrect findings with evidence.
2729Prove claims such as "one reader", "pure move", or "no shim left" with search or ` git diff -M90% ` .
28- Encode repeated findings as types, structure, checks, or tests. Remove prose reminders once enforced.
0 commit comments