You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 69032ca
Browse filesBrowse the repository at this point in the historyBrowse files
fix(interaction): register --expect-screenshot-diff in the guarantee matrix, settle the after-frame, and document the out-of-tree readback
Review fixes for the press/click --expect-screenshot-diff PR:
- The guarantee matrix (ADR 0011) gains the screenshotDiffEvidence row:
runtime cells on runtime-selector/runtime-ref/coordinate scoped to
press/click, a delegated cell on native-ref, and inapplicable cells on
the paths the flag cannot reach. The three waivers that named only
--verify/--settle as the opt-in post-action evidence routes now name
this flag too. Each enforced cell carries a contract scenario, and the
shared harness replays a solid-color frame plan.
- The after-frame waits 150ms past the dispatch reply before it is
captured: the reaction the flag asks about can render frames after the
transport round trip returns, and an immediate frame would read an
effective tap as unchanged. The flag help text, field descriptions,
and schema prose state the timing instead of leaving it blank.
- commands.md names the flag where it teaches that a successful press is
not proof of effect: a PIN keypad target is the case --verify cannot
answer, since it compares empty trees.
- Gate drift the PR introduced: the new capture-kit export joins the
layering manifest baseline, and the flag descriptor gate moves to
test/repo-guards/ (a repo-level guard on command descriptors, not a
module's unit test — R84 test-colocation).
Co-Authored-By: Claude Code <[email protected]>
'Press/click: compare lightweight screenshots taken right before and after the dispatch and report screenshotDiff in the response; use it when the target lives outside the accessibility tree (a PIN keypad) and --verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect',
215
+
'Press/click: compare lightweight screenshots taken right before the dispatch and after it settles briefly, and report screenshotDiff in the response; use it when the target lives outside the accessibility tree (a PIN keypad) and --verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect',
'Whether any pixel moved between the screenshots taken right before and after the dispatch. false means the frames match, which reads as "the dispatch may have had no visible effect" next to the response warning.',
90
+
'Whether any pixel moved between the screenshots taken right before the dispatch and after it settles briefly. false means the frames match, which reads as "the dispatch may have had no visible effect" next to the response warning.',
91
91
),
92
92
changedPixelRatio: numberSchema(
93
93
'Share of pixels whose color moved between the two frames. Absent when the frames could not be compared, for example a shape change.',
94
94
),
95
95
},
96
96
['changedFromBefore'],
97
-
'Pixel comparison between the screenshots taken right before and after the dispatch. Absent when the pair was not taken, which claims nothing about the screen.',
97
+
'Pixel comparison between the screenshots taken right before the dispatch and after it settles briefly. Absent when the pair was not taken, which claims nothing about the screen.',
Copy file name to clipboardExpand all lines: packages/command-surface/src/interaction/metadata.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -87,7 +87,7 @@ type InteractionCommandName = keyof typeof interactionCommandDescriptions;
87
87
88
88
constexpectScreenshotDiffField=()=>
89
89
booleanField(
90
-
'Compare lightweight screenshots taken right before and after the dispatch, and report the comparison as screenshotDiff in the response. Use it when the target lives outside the accessibility tree, such as a PIN keypad, where verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect.',
90
+
'Compare lightweight screenshots taken right before the dispatch and after it settles briefly, and report the comparison as screenshotDiff in the response. Use it when the target lives outside the accessibility tree, such as a PIN keypad, where verify would compare empty trees. A matching pair adds a warning, because the dispatch may have had no visible effect.',
'gap: the response reports the dispatch only; only opt-in --verify/--settle capture post-action evidence into it. The deferred marks set after dispatch (Android snapshot freshness after press/click, post-gesture stabilization when the request sets postGestureStabilization) are judged by the next capture, never in this response. An iOS Simulator open that did not read the launched app (any postOpenObservation other than observable) marks the next capture in that session to wait for a quiet surface (markPostOpenStabilization); that steadies where a target is resolved, not whether the tap landed. The iOS ambiguous-failure corroboration reconsiders only a thrown runner error.',
196
+
'gap: the response reports the dispatch only; only the opt-in --verify, --settle, and --expect-screenshot-diff features capture post-action evidence into it. The deferred marks set after dispatch (Android snapshot freshness after press/click, post-gesture stabilization when the request sets postGestureStabilization) are judged by the next capture, never in this response. An iOS Simulator open that did not read the launched app (any postOpenObservation other than observable) marks the next capture in that session to wait for a quiet surface (markPostOpenStabilization); that steadies where a target is resolved, not whether the tap landed. The iOS ambiguous-failure corroboration reconsiders only a thrown runner error.',
"gap: this replay-only route observes no outcome beyond the runner's own report; --verify/--settle do not apply here (see the inapplicable cells on this row), and the shared ambiguous-failure corroboration only reconsiders a thrown error, never a successful dispatch.",
209
+
"gap: this replay-only route observes no outcome beyond the runner's own report; --verify/--settle/--expect-screenshot-diff do not apply here (see the inapplicable cells on this row), and the shared ambiguous-failure corroboration only reconsiders a thrown error, never a successful dispatch.",
via: '--settle disables the native ref fast path when the descriptor post-action observation trait supports settle observation — settling needs the tree-based baseline and captures',
465
482
},
483
+
screenshotDiffEvidence: {
484
+
kind: 'delegated',
485
+
to: 'runtime-ref',
486
+
via: '--expect-screenshot-diff disables the native ref fast path, because the fast path never reaches the screenshot bracket that only the runtime dispatch runs under',
'gap: the fast path observes no post-action outcome by default; --settle/--verify disable it and delegate to runtime-ref instead of running here.',
501
+
'gap: the fast path observes no post-action outcome by default; --settle/--verify/--expect-screenshot-diff disable it and delegate to runtime-ref instead of running here.',
reason: 'The eligibility gate excludes --settle from this replay-only route.',
693
726
},
727
+
screenshotDiffEvidence: {
728
+
kind: 'inapplicable',
729
+
reason:
730
+
'The eligibility gate excludes --expect-screenshot-diff from this replay-only route: the fused runner request never reaches the screenshot bracket, so the flag routes the dispatch back to the runtime path.',
731
+
},
694
732
errorTaxonomy: {
695
733
kind: 'waived',
696
734
reason: 'gap: Maestro preserves the runner-native direct-selector error shapes.',
reason: 'Replay-only path; --settle is not part of replay semantics.',
755
793
},
794
+
screenshotDiffEvidence: {
795
+
kind: 'inapplicable',
796
+
reason:
797
+
'The eligibility gate excludes --expect-screenshot-diff from the replay-only routes, so a flagged dispatch re-routes to the runtime path before this fallback can be selected.',
798
+
},
756
799
errorTaxonomy: {
757
800
kind: 'waived',
758
801
reason: 'gap: shares the direct path error shapes, including their missing hints.',
0 commit comments