You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6764cfb
Browse filesBrowse the repository at this point in the historyBrowse files
fix(screenshot): carry burst frames through the client boundary and bound the burst run
Review follow-up on e406a40:
- client: normalizeScreenshotCaptureResult and pickScreenshotResultData keep the
burst frames, so the SDK default path and the CLI default --json output report
every frame path and capture time as the help promises; a frame without a path
and a wall clock is dropped and the array stays within the burst ceiling
- burst admission models the whole run, not just the waits: count 2-100, and
count * (intervalMs + 500 ms capture allowance per frame) within 60 s, so an
admitted burst cannot outrun the screenshot request envelope and reset the daemon
- screenshot reads count/intervalMs only when the invocation names them
(explicit-only in the CLI parser and in the MCP config defaults): a repository
count tuned for press and swipe series no longer arms a burst nor refuses
--crop-on beside it
- burst warnings dedupe across frames and stay within one note per frame
- the scripted --pixel-density error text keeps its released wording
Co-Authored-By: Claude Code <[email protected]>
// A burst arms a multi-file write, so only the invocation that names the flags may start one.
77
+
// The count and wait serve press and swipe series too, and a repository `count` set for those
78
+
// must not turn a single capture into a burst, nor refuse --crop-on beside it.
79
+
explicitOnlyFlags: ['count','intervalMs'],
80
+
flagDescriptionOverrides: {
81
+
count:
82
+
'Burst: capture this many frames of one animation in one request into a numbered file sequence (2-100). The CLI reads it only from this invocation; a config count for press and swipe series never arms a burst',
83
+
intervalMs:
84
+
'Burst: wait this many milliseconds between frames (100-10000, default 100). Requires --count, and like --count it is read only from this invocation',
"Web defaults to the viewport; use --fullscreen, --full, or -f for the entire page. iOS simulators default to 1x logical-point output; use --pixel-density to request a different screenshot density. Use --screen-mask black to fill the iOS simulator screen outline, including rounded corners, with black for this capture. It requires simctl: physical devices, tvOS and visionOS simulators, other platforms, provider captures and XCTest runner captures are refused. A masked capture fails if simctl fails instead of falling back to an unmasked runner capture. macOS app sessions default to the app window; use --fullscreen for full desktop, --scale to downscale, --crop-on <selector> to crop the capture to the frame the selector resolves on the same screen (currently iOS simulators, Android emulators, and CoreDevice physical iPhones), --overlay-refs to annotate current refs, --normalize-status-bar for deterministic iOS simulator or Android chrome. Physical iPhone crop verification covers portrait CoreDevice/devicectl captures only. XCTest, runner fallback, and physical iPad crops are refused; landscape iPhone crop is unverified. Android captures immediately by default; --normalize-status-bar also waits for transient UI to fade, and --no-stabilize keeps capture immediate. Use --count with --interval-ms to capture an animation burst in one request. The daemon captures frames sequentially and writes each frame as a numbered file beside the --out path, for example page-0001.png, and the result reports every frame path and capture time. A burst refuses --crop-on and --overlay-refs, because a crop binds one snapshot and overlay refs annotate one frame. Keep --count times --interval-ms within 30 seconds, because the frames must finish inside the request timeout. When --count is present without --interval-ms, the daemon waits 100ms between frames. With the native macOS backend, the front window is the app's frontmost visible, nonempty normal-level (layer-0) window on the current Space: floating palettes and app-modal alerts at window level 8 are skipped, and a sheet is captured as its own window. On macOS, any --surface other than app (desktop, menubar, frontmost-app) always captures the main display and refuses an explicit --fullscreen. On single-display iOS simulators and Android devices, the result reports displayRotation, the rotation the display rendered the capture in, when the device returns a reading in time; otherwise the field is absent. On iOS simulators a screenshot waits for that simulator's status bar to be free, and a request its caller cancelled while it waits reports the cancellation instead of capturing.",
109
+
"Web defaults to the viewport; use --fullscreen, --full, or -f for the entire page. iOS simulators default to 1x logical-point output; use --pixel-density to request a different screenshot density. Use --screen-mask black to fill the iOS simulator screen outline, including rounded corners, with black for this capture. It requires simctl: physical devices, tvOS and visionOS simulators, other platforms, provider captures and XCTest runner captures are refused. A masked capture fails if simctl fails instead of falling back to an unmasked runner capture. macOS app sessions default to the app window; use --fullscreen for full desktop, --scale to downscale, --crop-on <selector> to crop the capture to the frame the selector resolves on the same screen (currently iOS simulators, Android emulators, and CoreDevice physical iPhones), --overlay-refs to annotate current refs, --normalize-status-bar for deterministic iOS simulator or Android chrome. Physical iPhone crop verification covers portrait CoreDevice/devicectl captures only. XCTest, runner fallback, and physical iPad crops are refused; landscape iPhone crop is unverified. Android captures immediately by default; --normalize-status-bar also waits for transient UI to fade, and --no-stabilize keeps capture immediate. Use --count with --interval-ms to capture an animation burst in one request. The daemon captures frames sequentially and writes each frame as a numbered file beside the --out path, for example page-0001.png, and the result reports every frame path and capture time. A burst refuses --crop-on and --overlay-refs, because a crop binds one snapshot and overlay refs annotate one frame. Keep --count times --interval-ms plus 500 ms per frame within 60 seconds, because the frames must finish inside the request timeout. When --count is present without --interval-ms, the daemon waits 100ms between frames. A burst starts only when this invocation names --count; a count set for press and swipe in a config file never arms one. With the native macOS backend, the front window is the app's frontmost visible, nonempty normal-level (layer-0) window on the current Space: floating palettes and app-modal alerts at window level 8 are skipped, and a sheet is captured as its own window. On macOS, any --surface other than app (desktop, menubar, frontmost-app) always captures the main display and refuses an explicit --fullscreen. On single-display iOS simulators and Android devices, the result reports displayRotation, the rotation the display rendered the capture in, when the device returns a reading in time; otherwise the field is absent. On iOS simulators a screenshot waits for that simulator's status bar to be free, and a request its caller cancelled while it waits reports the cancellation instead of capturing.",
`screenshot --count schedules ${scheduledWaitMs} ms of waits; keep the burst within ${SCREENSHOT_BURST_LIMITS.maxScheduledWaitMs} ms by lowering --count or --interval-ms, or capture in a batch`,
480
+
`screenshot --count schedules ${runMs} ms of waits and captures; keep the burst within ${SCREENSHOT_BURST_LIMITS.maxRunMs} ms by lowering --count or --interval-ms, or capture in a batch`,
0 commit comments