Skip to content

Commit 6600f5e

Browse files
authored
chore(deps): update fallow to 3.34.0 (#3789)
* chore(deps): update fallow to 3.34.0 * test(harmonyos): isolate host toolchain environment * chore(gates): scope Fallow audit to checked-out PR changes
1 parent 72e7965 commit 6600f5e

7 files changed

Lines changed: 57 additions & 59 deletions

File tree

‎.fallowrc.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"examples/sdk/contracts-result.ts",
4242
"examples/sdk/batch-orchestration.ts",
4343
"examples/sdk/ai-sdk-tools.ts",
44-
"test/integration/*.test.ts",
44+
"test/integration/**/*.test.ts",
4545
"website/docs/404.mdx",
4646
"website/rspress.config.ts"
4747
],
@@ -351,7 +351,7 @@
351351
},
352352
{
353353
// Host-kit seam façades: same false-positive shape as the contracts façades above — each seam names every type its re-exported functions put in a public signature, and callers use those types structurally without importing the name. unused-exports (the VALUE check) stays on.
354-
"files": ["packages/host-kit/src/*.ts"],
354+
"files": ["packages/host-kit/src/**/*.ts"],
355355
"rules": {
356356
"unused-types": "off"
357357
}

‎.github/workflows/ci.yml‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,14 +148,15 @@ jobs:
148148
- name: Setup toolchain
149149
uses: ./.github/actions/setup-node-pnpm
150150

151-
# The fallow audit runs in the background beside the guards below. A cold fallow run costs
152-
# several minutes on a hosted runner: since fallow 3.20 every import re-walks the root
153-
# tsconfig's project references.
151+
# Run the Fallow audit beside the guards below. Wait before production-exports uses
152+
# the same cache directory.
154153
- name: Run Fallow audit
155154
id: fallow-audit
156155
background: true
157156
env:
158-
FALLOW_BASE: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.before }}
157+
# The event base can lag behind the merge tree checked out for a PR.
158+
# Compare with its main parent so the audit measures only the PR changes.
159+
FALLOW_BASE: ${{ github.event_name == 'pull_request' && 'HEAD^1' || github.event.before }}
159160
uses: ./.github/actions/run-gate
160161
with:
161162
gate: fallow

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@
340340
"ai": "^7.0.68",
341341
"eslint-plugin-no-only-tests": "^3.4.0",
342342
"eslint-plugin-perfectionist": "^5.10.1",
343-
"fallow": "3.32.0",
343+
"fallow": "3.34.0",
344344
"fast-check": "^4.9.0",
345345
"ipaddr.js": "^2.5.0",
346346
"jpeg-js": "^0.4.4",

‎packages/platform-harmonyos/src/__tests__/hdc.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ test('ensureHarmonyToolchainPathConfigured defaults to the host environment', as
143143
const toolchains = await seedDirectToolchain(mkdtempForTestSync('agent-device-hdc-host-'));
144144
vi.stubEnv('PATH', '/usr/bin');
145145
vi.stubEnv('HDC_SDK_PATH', toolchains);
146+
vi.stubEnv('DEVECO_SDK_HOME', undefined);
147+
vi.stubEnv('HARMONYOS_COMMAND_LINE_TOOLS', undefined);
146148

147149
await ensureHarmonyToolchainPathConfigured();
148150

‎pnpm-lock.yaml‎

Lines changed: 41 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎scripts/layering/project-references.test.ts‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,11 @@ test('root and examples/sdk reference exactly the workspace package set', () =>
5959
});
6060

6161
test('the root build node is tsconfig.json plus references, and tsconfig.json has none', () => {
62-
// fallow >=3.20 walks the references of the tsconfig that owns each file on every import, which
63-
// made its resolve stage ~14x slower here, and `fr` loads every referenced project as its own
64-
// ts.Program, which exhausts Node's default heap (#3289 CI). `extends` does not inherit
65-
// references, so the typecheck node carries them without fallow, fr, editors, or tsdown seeing them.
62+
// `fr` loads every referenced project as its own ts.Program, which exhausts Node's default
63+
// heap (#3289 CI). `extends` does not inherit references, so the typecheck node carries them
64+
// without fr, editors, or tsdown seeing them.
6665
const rootConfig = readTsconfig('tsconfig.json');
67-
assert.equal(
68-
rootConfig.references,
69-
undefined,
70-
'references on tsconfig.json slow every fallow gate and OOM freerange',
71-
);
66+
assert.equal(rootConfig.references, undefined, 'references on tsconfig.json OOM freerange');
7267
const typecheckConfig = readTsconfig('tsconfig.typecheck.json');
7368
assert.equal(typecheckConfig.extends, './tsconfig.json');
7469
assert.equal(

‎tsconfig.typecheck.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
// The `tsc -b` node for the root program. References live here, not in tsconfig.json, because
3-
// fallow and freerange read tsconfig.json and slow down or run out of memory on references.
2+
// The `tsc -b` node for the root program. References live here because freerange reads
3+
// tsconfig.json and runs out of memory when it loads every referenced project.
44
// Its own build info keeps a `tsc -p tsconfig.json` run from marking this build up to date.
55
"extends": "./tsconfig.json",
66
"compilerOptions": { "tsBuildInfoFile": "./.tmp/tsconfig.typecheck.tsbuildinfo" },

0 commit comments

Comments
 (0)