Repository navigation
Commit 63fd297
committed
refactor(layering): R11 keeps every relative package escape, compiled or not
Maintainer review on #3289: `if (compiled) continue;` retired more than tsc
replaces. Planted the reviewer's exact case:
packages/host-kit/src/r11-planted-sibling-tunnel.ts
import { AppError } from '../../kernel/src/errors.ts';
pnpm exec tsc -b packages/host-kit --force -> exit 0, no diagnostics
The reference redirects kernel's sources to their dist-types .d.ts, so nothing
outside host-kit's rootDir is emitted and neither TS6059 nor TS6307 fires -
the #3279 proof held only for the ROOT escape (TS2307 there, no project
redirects it). The sibling tunnel breaks runtime identity instead: Node loads
kernel once by path and once by specifier, so two AppError classes coexist and
instanceof fails - invisible to any compiler. The escape branch returns for
every package source; only the RESOLUTION branches (unknown package,
un-exported subpath) stay compiler-owned. checkPackageInternalSites gains the
requested compiled=true sibling-tunnel test, mutation-proven: re-adding the
skip turns it, the escape test, and the quote-form test red.
The non-blocking items are taken, both true: project-references.test.ts now
asserts the root include list (pinning the help-conformance divergence the
predicate's doc block promises) and the per-package include:[src]/no-exclude
shape insideCompiledSources' regexes assume - mutation: adding an exclude to
xml or a second scripts entry to root goes red - and check.ts's R11 summary
line states the corrected split.1 parent f75da8b commit 63fd297
4 files changed
Lines changed: 99 additions & 23 deletions
File tree
- scripts/layering
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
234 | | - | |
235 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
244 | 253 | | |
245 | 254 | | |
246 | 255 | | |
247 | | - | |
248 | | - | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
249 | 275 | | |
250 | 276 | | |
251 | 277 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
156 | 158 | | |
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
160 | | - | |
161 | | - | |
162 | | - | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
163 | 167 | | |
164 | 168 | | |
165 | 169 | | |
| |||
169 | 173 | | |
170 | 174 | | |
171 | 175 | | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
177 | 187 | | |
178 | 188 | | |
179 | 189 | | |
| |||
184 | 194 | | |
185 | 195 | | |
186 | 196 | | |
187 | | - | |
188 | 197 | | |
189 | 198 | | |
190 | 199 | | |
| |||
194 | 203 | | |
195 | 204 | | |
196 | 205 | | |
197 | | - | |
198 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
199 | 209 | | |
200 | 210 | | |
201 | 211 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
58 | 97 | | |
59 | 98 | | |
60 | 99 | | |
| |||
0 commit comments