You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 616e843
Browse filesBrowse the repository at this point in the historyBrowse files
docs(ios): record the open-pose Duo evidence and the overlay exporter defect
The operator opened the Duo mid-verification, so the open pose is now evidence
rather than a gap: the capture names `LCD-1` at 951x669, taps resolve inside that
surface, typed text reads back, and a pre-fold ref is refused instead of replayed
at the new point size. What stays open is the quarter turn and the runner
fallback, both restated as gaps.
`recordVideo` gets the per-panel table that proves `--display` is honored
(2006x2852 luma 241.42 for the lit panel against 1398x2034 luma 0.00 for the
dark one), plus the separate finding that the touch-overlay exporter returns a
480x336 black video for the inner panel's rot90 track — reproducible by feeding a
raw simctl capture straight into the untouched `recording-overlay.swift`, and
fine on a non-rotated iPhone 17 export.
Also drop the pose and role wording from the decision table, since the inventory
no longer carries either.
Copy file name to clipboardExpand all lines: docs/adr/0025-foldable-apple-panels.md
+48-21Lines changed: 48 additions & 21 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -41,21 +41,24 @@ reader of CoreDevice display info.
41
41
guessing dark would aim a capture at a panel that may be showing nothing.
42
42
-**Panel identity.** A device is multi-screen when it reports more than one `type: integrated`
43
43
panel. CoreDevice marks one panel `primary`; that panel is the outer display, because it is the
44
-
panel that stays lit while the device is closed. The inner display is the largest remaining panel,
45
-
because a foldable's inner surface encloses the outer one. A third and later panel stays unroled
46
-
rather than being labelled `inner`, and a device with no `primary` panel gets **no** roles at all:
47
-
inventing them from CoreDevice's array order would silently invert the naming. When the primary
48
-
panel is also the largest, the `primary` attribute still decides and the conflict is emitted as a
49
-
diagnostic rather than silently repaired by a geometry rule.
44
+
panel that stays lit while the device is closed. `primary` and the lit count are the whole model:
45
+
the inventory labels panels `outer`/`inner` nowhere, because no caller consumes a label — every
46
+
decision is made from `primary` plus panel power, and a name derived from array order or from
47
+
geometry would be a second source of truth ready to invert silently. When the primary panel is
48
+
also the largest, the `primary` attribute still decides and the conflict is emitted as
49
+
`apple_display_primary_geometry_conflict` rather than silently repaired by a geometry rule.
50
50
-**Capture target.**`resolveAppleCaptureDisplay` returns a panel for every multi-panel device and
51
51
`undefined` only for a single-panel device or an unresolved inventory. When panel power identifies
52
-
exactly one lit panel that panel is named; otherwise the `primary` panel is named anyway, the
53
-
pose is `unknown`, and `apple_display_capture_ambiguous` is emitted. A multi-panel device never
52
+
exactly one lit panel that panel is named; otherwise the `primary` panel is named anyway,
53
+
`ambiguous` is set, and `apple_display_capture_ambiguous` is emitted. A multi-panel device never
54
54
receives a display-less capture, because the implicit default is precisely the black-and-exit-0
55
55
failure being fixed; naming a possibly-dark panel is a visible, diagnosable miss instead.
56
-
-**Pose.**`deriveDisplayPose` reads panel power only: exactly one lit panel and it is
57
-
`primary` → `closed`; exactly one lit panel and it is not → `fully-open`; anything else
58
-
(both, neither, no `primary`) → `unknown`.
56
+
-**No pose field.** Panel power cannot separate Apple's `UIHinge.Status.fullyOpen` from
57
+
`.partiallyOpen` — both leave the inner panel lit and the outer panel dark — so a derived pose
58
+
could only ever mean "not closed" while looking like a fact. The inventory therefore reports what
59
+
it measured (`primary`, panel power, geometry, orientation) and leaves pose to the app under test,
60
+
which can read `UIHinge.status` exactly. A caller that needs the pose asks the operator and
61
+
re-snapshots.
59
62
-**No cache.** The probe runs per capture. Which panel is lit is precisely what an operator
60
63
changes by folding or opening the device, so a cached inventory would resume capturing the dark
61
64
panel — the exact failure being fixed. The probe runs under
@@ -72,6 +75,7 @@ whose content is black, so every downstream consumer trusts a capture of nothing
72
75
| Capture path | Before | After |
73
76
| --- | --- | --- |
74
77
|`screenshot` on a closed Duo | 669x951 @1x, mean luma 0.09 (black) | 466x678 @1x, mean luma 65.8 (the lit outer panel) |
78
+
|`screenshot` on an open Duo | 951x669 @1x, mean luma 241 (correct by luck: the highest screen ID is the lit inner panel) | 951x669 @1x naming `LCD-1` explicitly |
75
79
|`screenshot` on iPhone 17 | 402x874 @1x, mean luma 104.9 | unchanged |
76
80
77
81
This is the failure behind reports that the tool "picks the wrong screen" on iPhone Duo. It was
@@ -145,11 +149,36 @@ coordinates do not survive it. `agent-device help foldable` states this and stat
145
149
report which poses remain unverified rather than assume a pose was set.
146
150
147
151
`simctl io recordVideo` has the same implicit-display default as `screenshot`, so recording names
148
-
the lit panel through the same resolver.
152
+
the lit panel through the same resolver. On an open Duo the 27.1 toolchain accepts the panel name
153
+
and honors it per panel; sampled mean luma over the whole frame:
0 commit comments