Repository navigation
Commit 5fb2860
authored
fix: carry response warnings to every surface, and stamp the sheet behind a refusal (#2571)
* fix(replay): carry optional-skip warnings to every human surface and name system surfaces in refusals
An optional: true Maestro step that skipped stayed a warning that the
terminal never printed once a later step failed: the accumulated channel
rode only on the success response, so the repro run in #2560 reported a
bare failure with no trace of the skip. The engine now emits warnings on
the failure event, the daemon copies them onto the failure response's
error details, and the failed test result carries the same array the
passed result already had; replay prints them through its facet formatter
and the test reporter adds a Warnings section that renders whether tests
pass or fail.
A regular iOS presentation refusal from the runner now also carries the
registry identity of the system surface the tree was acquired from in
error details, so a capture-boundary miss under optional: true stops
looking like a selector problem; the sparse-declared verdict path is
owned by #2572.
* fix(replay): surface warnings on failed runs and keep them honest
A failing `replay` still printed no trace of the run's accumulated warnings:
the human error renderer read message, hint, and divergence but never the
error-level warnings channel, so the pass/fail asymmetry survived on that
surface. It now prints each warning after the error.
Round-two corrections: warnings on the divergence response are scrubbed
against replay vars like message and hint already are; a failed attempt
copies warnings only when non-empty, matching the passing branch; the
optional-skip hint append is removed because no producer of a maestro test
failure emits a hint — capture-error lineage stays with #2450 — along with
the CHANGELOG claim it rested on; the failed-result copy gains its own
module test, and JUnit covers a failed test's warning lines.
* refactor(replay-test): make an attempt failure's warnings channel always present
An empty array and an absent key said the same thing two ways, so every
consumer needed both guards. The failed outcome now always carries the
warnings array, like the passed outcome already did, and the result builder
narrows the attempt once instead of per field. This also removes the clone
the shared candidate-view formatter had grown between the CLI and MCP error
renderers — the MCP error text gained the same warnings lines the CLI
stderr prints.
* refactor(kernel): own the response-warnings field contract beside the message reader
Four call sites read the composable warnings field with their own
Array.isArray filters (the daemon append, the daemon attempt outcome, the
CLI success line, the CLI/MCP error text), and the PR had grown a fifth.
The field has one contract now: kernel/success-text readResponseWarnings,
next to readCommandMessage, with the daemon append, the attempt outcome,
messageWithWarningsText, and both error renderers as its named consumers.
The CLI-side reader the PR introduced is deleted, not wrapped.1 parent e3cbc91 commit 5fb2860
43 files changed
Lines changed: 747 additions & 80 deletions
File tree
- packages
- contracts/src
- kernel/src
- maestro/src/internal
- __tests__
- platform-apple/src/runner
- __tests__
- replay-test/src/internal
- __tests__
- src
- client
- cli
- commands/__tests__
- replay-test
- __tests__
- reporters
- __tests__
- commands
- output
- replay
- daemon
- __tests__
- replay/internal
- __tests__
- session-lifecycle/internal
- __tests__
- mcp
- __tests__
- website/docs/docs
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
142 | 155 | | |
143 | 156 | | |
144 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
| 112 | + | |
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
60 | 63 | | |
61 | 64 | | |
62 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
337 | 369 | | |
338 | 370 | | |
339 | 371 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
| 142 | + | |
141 | 143 | | |
142 | 144 | | |
143 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
215 | 217 | | |
216 | 218 | | |
217 | 219 | | |
| 220 | + | |
218 | 221 | | |
219 | 222 | | |
220 | 223 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| 99 | + | |
99 | 100 | | |
100 | 101 | | |
101 | 102 | | |
| |||
0 commit comments