Repository navigation
Commit 5ee129a
committed
fix(ci): close the last two construction holes — typed inputs, per-file digest
Two findings that had each been reported three times.
P1, the `INPUT_*` smuggle. An action binds `INPUT_COMMAND: ${{ inputs.command }}`
and runs the constant body `bash -c "$INPUT_COMMAND"`; the digest never moves
however callers change the value.
Asking what a body DOES with a variable is the content analysis this design
refuses, and it would lose to `eval`, bare `$X` and indirect expansion. Asking
whether a body MENTIONS it is a substring scan. So the loader finds every input
an action dereferences into shell, and the constraint lands on the caller's
VALUE, which is a literal here and therefore decidable: each such input declares
the exact set of values callers may pass. A command cannot be a member of a
closed set of literals, so the reported attack is unrepresentable rather than
policed. Nine inputs across three actions is the entire surface; `gate` is
exempt because GATE_ACTIONS already constrains it to a registered CheckId,
which is tighter.
P2, the census. The previous commit pinned each file's step COUNT, which stops
an addition. It does not stop a replacement: `census()` dedupes by
{source, digest}, so swapping one non-gate body for another leaves arity
identical, and `--update` records the new digest under unchanged prose.
Confirmed by swapping a linux.yml body for `node -e 'import(...)'` — 90 entries,
`ok`. Each file now also pins a fingerprint over every digest it contributes, so
add, delete and edit all move a hand-written value. That is the explicit owned
waiver the review asked for, as 21 fingerprints rather than 90 prose entries.
Both attacks re-run verbatim after the fix, each with `--update` first, and both
now fail. Three checked-in regressions, all regenerating the baseline before
asserting.
Also: two declared input values turned out to be passed by nobody, caught by the
ablation that requires every declared value to be load-bearing.
77 gate tests. Manifest, lint, typecheck, format, layering, depgraph,
production-exports, fallow and trusted-fixture-artifact green locally. Diff
verified as text — no tracked TypeScript source contains a raw NUL.1 parent c859a11 commit 5ee129a
5 files changed
Lines changed: 382 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
434 | 434 | | |
435 | 435 | | |
436 | 436 | | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
437 | 502 | | |
438 | 503 | | |
439 | 504 | | |
| |||
450 | 515 | | |
451 | 516 | | |
452 | 517 | | |
453 | | - | |
| 518 | + | |
454 | 519 | | |
455 | 520 | | |
456 | 521 | | |
| |||
462 | 527 | | |
463 | 528 | | |
464 | 529 | | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
465 | 556 | | |
466 | 557 | | |
467 | 558 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| 36 | + | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
| |||
392 | 395 | | |
393 | 396 | | |
394 | 397 | | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
395 | 455 | | |
396 | 456 | | |
397 | 457 | | |
| |||
412 | 472 | | |
413 | 473 | | |
414 | 474 | | |
415 | | - | |
| 475 | + | |
| 476 | + | |
416 | 477 | | |
417 | 478 | | |
418 | | - | |
| 479 | + | |
419 | 480 | | |
420 | | - | |
421 | | - | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
422 | 490 | | |
423 | 491 | | |
424 | 492 | | |
425 | | - | |
426 | | - | |
427 | | - | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
428 | 496 | | |
429 | 497 | | |
430 | 498 | | |
| |||
433 | 501 | | |
434 | 502 | | |
435 | 503 | | |
436 | | - | |
| 504 | + | |
437 | 505 | | |
438 | 506 | | |
439 | 507 | | |
| |||
533 | 601 | | |
534 | 602 | | |
535 | 603 | | |
| 604 | + | |
536 | 605 | | |
537 | 606 | | |
538 | 607 | | |
539 | 608 | | |
540 | 609 | | |
541 | 610 | | |
542 | 611 | | |
| 612 | + | |
543 | 613 | | |
544 | 614 | | |
545 | 615 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
40 | 62 | | |
41 | 63 | | |
42 | 64 | | |
| |||
0 commit comments