You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5da9f1b
Browse filesBrowse the repository at this point in the historyBrowse files
refactor: make the selection resolver the sole owner of selection provenance
Simplifies the deterministic device-selection resolver (net -114 lines vs the
previous head) while fixing the outstanding app-aware provenance finding:
- Move the booted-simulator app-affinity narrowing into the resolver behind an
appleSimulatorAppTarget param, with its own typed reason
'single-app-installed-local' (candidateCount 1). This removes the
selectedDevice escape hatch that reported 'preferred-local' with
candidateCount 2 for the app-narrowed pick, and gives the app-match errors
the same platform-aware retry selectors as every other selection failure.
- Delete dead code: the allowBootableLocal param (no caller ever passed it, so
the eligibleDevices filter was unreachable), the hasExplicitProviderIdentity
alias, the duplicated deviceCandidateDetails in dispatch-resolve, and the
double candidate computation.
- Shrink the public selection contract to what #1777 specifies: drop `booted`
(it contradicted its own doc comment once markSelectionBootedAfterPreparation
flipped it; bootOccurred plus the reason codes carry the same information)
and drop `retrySelectors` from success metadata (the daemon only ever emits
retry selectors inside error details). DeviceSelectionRetrySelector leaves
the contracts facade.
- Replace the typeof-import lazy seam and resolver threading through four
context objects with one lazy forwarding wrapper; the dispatch eager closure
stays at 83.
- Collapse the Apple path to resolve -> optional simulator fallback; the
provider branch goes through the generic resolver call directly.
- Consolidate the five copy-pasted resolveTargetDeviceSelection test mocks
into one shared stub (selectionFromResolveTargetDevice).
- Add the requested regression: two booted simulators with the app on one now
assert typed selection metadata through resolveTargetDeviceSelection, plus a
resolver-level app-affinity provenance test.
Validation: typecheck, oxlint, oxfmt, layering (184-check guard OK), DI seams,
fallow changed-files, eager-closure 235/235, daemon suite 323 files / 2287
tests, core/commands/mcp/client suites 255 files / 2133 tests.
0 commit comments