Skip to content

Commit 5b01449

Browse files
committed
ci: preserve size reporter modules across base checkout
1 parent a53dbd2 commit 5b01449

3 files changed

Lines changed: 49 additions & 2 deletions

File tree

‎.github/workflows/size.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ jobs:
4141
uses: ./.github/actions/setup-node-pnpm
4242

4343
- name: Preserve report scripts
44-
run: cp scripts/size-report*.mjs /tmp/
44+
run: |
45+
mkdir -p /tmp/agent-device-size-report
46+
cp scripts/size-report*.mjs /tmp/agent-device-size-report/
4547
4648
# dist is fully determined by the base commit, so reuse it across PR runs
4749
# against the same base. Startup medians are still measured fresh on this
@@ -60,7 +62,7 @@ jobs:
6062
if [ "${{ steps.base-dist-cache.outputs.cache-hit }}" != "true" ]; then
6163
pnpm build
6264
fi
63-
node /tmp/agent-device-size-report.mjs \
65+
node /tmp/agent-device-size-report/size-report.mjs \
6466
--startup-runs 7 \
6567
--json /tmp/agent-device-size-base.json
6668

‎test/ci/size-workflow.test.ts‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
import fs from 'node:fs';
2+
import path from 'node:path';
3+
import { expect, test } from 'vitest';
4+
import { parse } from 'yaml';
5+
6+
const repoRoot = path.resolve(import.meta.dirname, '../..');
7+
const preservedReportDir = '/tmp/agent-device-size-report';
8+
9+
type WorkflowStep = { name?: string; run?: string };
10+
type WorkflowDoc = {
11+
jobs?: Record<string, { steps?: WorkflowStep[] }>;
12+
};
13+
14+
function workflowStep(name: string): WorkflowStep {
15+
const workflow = parse(
16+
fs.readFileSync(path.join(repoRoot, '.github/workflows/size.yml'), 'utf8'),
17+
) as WorkflowDoc;
18+
const step = workflow.jobs?.['bundle-size']?.steps?.find((candidate) => candidate.name === name);
19+
if (!step) {
20+
throw new Error(`size.yml must declare the ${JSON.stringify(name)} step`);
21+
}
22+
return step;
23+
}
24+
25+
test('the preserved size reporter keeps its entrypoint and relative modules together', () => {
26+
const preserve = workflowStep('Preserve report scripts').run ?? '';
27+
const measureBase = workflowStep('Measure base size').run ?? '';
28+
29+
expect(preserve).toContain(`mkdir -p ${preservedReportDir}`);
30+
expect(preserve).toContain(`cp scripts/size-report*.mjs ${preservedReportDir}/`);
31+
expect(measureBase).toContain(`node ${preservedReportDir}/size-report.mjs`);
32+
33+
const reportSource = fs.readFileSync(path.join(repoRoot, 'scripts/size-report.mjs'), 'utf8');
34+
const relativeModules = [...reportSource.matchAll(/from '\.\/(size-report-[^']+\.mjs)'/g)].map(
35+
(match) => match[1],
36+
);
37+
expect(relativeModules.length).toBeGreaterThan(0);
38+
for (const moduleName of relativeModules) {
39+
if (!moduleName) throw new Error('relative size-report import has no module name');
40+
expect(fs.existsSync(path.join(repoRoot, 'scripts', moduleName)), moduleName).toBe(true);
41+
}
42+
});

‎vitest.config.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ export default defineConfig({
9797
'scripts/__tests__/size-report-package.test.ts',
9898
// Parses CI configuration only, so this action guard needs no device or subprocess lane.
9999
'test/ci/upload-agent-device-artifacts.test.ts',
100+
// The size reporter is preserved across a base checkout; its entrypoint and imported
101+
// modules must move as one directory or the Bundle Size lane fails before measuring.
102+
'test/ci/size-workflow.test.ts',
100103
// #1781 A9: pins the root-doc paths-ignore entries directly against the
101104
// real workflow YAML, parse-only like its sibling above.
102105
'test/ci/root-docs-paths-ignore.test.ts',

0 commit comments

Comments
 (0)