Repository navigation
Commit 59ee3ec
committed
test(daemon): stub the dialog probe where this branch moved it
PR #2003 CI, coverage shard: 'request router joins orientation admission to
execution and ref invalidation' failed with `{ ok: false, error }` where it
expects `{ ok: true, data }`.
`orientation` carries `androidBlockingDialogGuard: true`, so the router runs the
real `ensureNoAndroidBlockingDialogReady` check for this file's Android device.
This branch moved `getAndroidBlockingDialogObservation` out of `app-lifecycle.ts`
and into `window-state.ts`, which answers every window question from one dumpsys
read. The sibling suites moved their stubs with it; this one kept aiming at the
old module, where the spread only added a key nothing imports. The stub was a
silent no-op and the real `adb` spawn ran.
A host with `adb` on PATH still passed: no such device, empty dump, `unknown`
status, warning path, `ok: true`. A runner without `adb` fails the spawn instead,
and the guard's catch turns that into an error response — the shard's failure.
Reproduced locally by dropping `adb` from PATH, which gives the CI assertion
verbatim; green there after the fix, and the case drops from 939ms to 9ms now
that it no longer spawns `adb` twice.
Production is unchanged: the guard is correct to gate orientation, which is
state-changing and would otherwise rotate behind a blocking dialog (#1832,
#592). Only the test's seam pin was stale.1 parent be0e48b commit 59ee3ec
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
11 | 15 | | |
12 | 16 | | |
13 | 17 | | |
| |||
0 commit comments