Skip to content

Commit 5914865

Browse files
committed
chore(gates): acknowledge bounded artifact diagnostic collection
1 parent 1c83a32 commit 5914865

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎test/wire-compat/ledger.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@
142142
"packages/daemon/src/server/upload-http.ts#sendJson": "sha256:c2317b4b14a10731684c9160038005965856150f05f8923765a3fa833d2ecae9",
143143
"packages/daemon/src/server/upload-http.ts#sendUploadedArtifactResponse": "sha256:9e418403448d58a96284fed605762fa71f9349bf2c70ad79df69b2b3e27487d6",
144144
"packages/remote/src/artifact-download.ts#RemoteArtifactDownload": "sha256:f73a888f4f8c9d603701c505bb342787b1ca6559a13b15da2385e60349ecea8e",
145-
"packages/remote/src/artifact-download.ts#downloadRemoteArtifactFromUrl": "sha256:0111afbb147ff167adec1fe64f729911b102d4f5324423d3df8bcc3caac21864",
145+
"packages/remote/src/artifact-download.ts#downloadRemoteArtifactFromUrl": "sha256:2e71ca375778c131e99a645a16b1f491d8dd6a10a3198d696e6138e46b601785",
146146
"packages/remote/src/daemon-artifacts.ts#DaemonArtifactEndpoint": "sha256:45226717ac52c0af2a62f74e91549582d95f4a4abc49be87989e026291a88c82",
147147
"packages/remote/src/daemon-artifacts.ts#DownloadRemoteArtifactParams": "sha256:ba6d2f6ac51e05ccc5e0c940b355d62374e018b1ae6f6f744becf6e1760cbb63",
148148
"packages/remote/src/daemon-artifacts.ts#buildDaemonArtifactUrl": "sha256:06dcde057809b507f70f7bb5cdef9bde6515be84b67e45865cf19e70b8636208",
@@ -452,8 +452,8 @@
452452
},
453453
{
454454
"declaration": "packages/remote/src/artifact-download.ts#downloadRemoteArtifactFromUrl",
455-
"digest": "sha256:0111afbb147ff167adec1fe64f729911b102d4f5324423d3df8bcc3caac21864",
456-
"rationale": "Clients name a held agent-device lease in an optional x-agent-device-lease-id request header on upload, artifact download and request diagnostics HTTP calls, so a gateway can route them. Released daemons ignore unknown request headers and the proxy forwards only its allowlist, so routes, bodies and responses parse as before; with no lease held the request is unchanged (ADR 0006). Client-only, implementation-compatible error repair: supported /artifacts downloads still return HTTP 200 with the same bytes, request headers and artifact framing. Redirect/error statuses now fail clearly instead of saving their bodies as artifacts; interrupted error responses settle with the existing COMMAND_FAILED category and numeric statusCode. The bounded body is local diagnostic context, not a new peer payload. Released daemons already return 200 for successful artifact downloads, so supported skewed peers parse the same successful framing (ADR 0006)."
455+
"digest": "sha256:2e71ca375778c131e99a645a16b1f491d8dd6a10a3198d696e6138e46b601785",
456+
"rationale": "Clients name a held agent-device lease in an optional x-agent-device-lease-id request header on upload, artifact download and request diagnostics HTTP calls, so a gateway can route them. Released daemons ignore unknown request headers and the proxy forwards only its allowlist, so routes, bodies and responses parse as before; with no lease held the request is unchanged (ADR 0006). Client-only, implementation-compatible error repair: supported /artifacts downloads still return HTTP 200 with the same bytes, request headers and artifact framing. Redirect/error statuses now fail clearly instead of saving their bodies as artifacts; interrupted error responses settle with the existing COMMAND_FAILED category and numeric statusCode. The bounded body is local diagnostic context, not a new peer payload. Once the diagnostic prefix is full, further chunks are consumed without concatenating or copying that retained prefix; error status and diagnostic contents are unchanged. Released daemons already return 200 for successful artifact downloads, so supported skewed peers parse the same successful framing (ADR 0006)."
457457
},
458458
{
459459
"declaration": "packages/daemon-client/src/daemon-client-progress.ts#shouldReadDaemonProgressStream",

0 commit comments

Comments
 (0)