You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5731692
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(daemon): take the four review findings, three of which delete code
Review on #1615, all non-blocking; applied rather than deferred because
three of the four remove lines.
1. Named the capture-strategy union. `SnapshotCaptureBackend` now lives in
kernel/snapshot beside `SnapshotBackend`, and `SnapshotQualityVerdict`
uses it. The two docblocks whose only job was saying what the type is
NOT (11 lines in types.ts, 4 on CapturedSurface) collapse to the
load-bearing #1569 comparability warning.
2. Trimmed comment mass. The key-vs-identity rationale said one thing
three times over 20 lines; it says it once. `rectsWithinTolerance` no
longer names its callers — that roster drifts the first time a fourth
lands. The test comment restating the (now deleted) docblock is gone;
the test name carries it.
That also fixes a drift already present: the removed docblock claimed
`gesture <subtype> …` reaches the warning by default, when
`isPostGestureStabilizingAction` only admits `gesture swipe`.
3. Deleted the scroll exception, the numeric heuristic's last vestige.
`describeGesturePositionals` and its 17-line docblock existed to
suppress one token (`scroll down 0.6` -> "scroll down"). Positionals
now echo verbatim: the warning names the gesture the agent issued, and
`scroll down 0.6` is what they issued. Helper, docblock and exception
all go; one test assertion updates.
4. `PostGestureStabilization.positionals` is required. Its only writer
always sets it, so `pending.positionals ?? []` guarded an impossible
state. Tightening it caught five test fixtures constructing the state
without the field — the type doing its job.
93 files / 733 tests green; typecheck, lint, format, check:layering clean.
0 commit comments