Skip to content

Commit 55bf069

Browse files
committed
refactor(apple): make every snapshot source declare observe-only support
observeOnlySupported was optional, and only an explicit false sent an observe-only capture to the direct fallback. A source that left it out was silently treated as supporting observe-only. The local source now declares true and the runner source false; the type requires it.
1 parent f1520e3 commit 55bf069

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎packages/platform-apple/src/runner-snapshot-bridge.test.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ function bridgeRoute(provider: AppleRunnerProvider, runnerSessionId?: string) {
164164
resolveTarget: bridge.resolveTarget,
165165
refreshTarget: (device, appBundleId, signal) =>
166166
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
167+
observeOnlySupported: false,
167168
...(runnerSessionId ? { sessionChanged: bridge.resetTargets } : {}),
168169
},
169170
async () =>
@@ -592,6 +593,7 @@ test('a late presentation failure cannot retire the replacement session generati
592593
resolveTarget: bridge.resolveTarget,
593594
refreshTarget: (device, appBundleId, signal) =>
594595
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
596+
observeOnlySupported: false,
595597
sessionChanged: bridge.resetTargets,
596598
},
597599
async () => ({ foreground: 'background', sessionId }),
@@ -654,6 +656,7 @@ test('a wedge before the runner id is known does not disable a newly identified
654656
resolveTarget: bridge.resolveTarget,
655657
refreshTarget: (device, appBundleId, signal) =>
656658
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
659+
observeOnlySupported: false,
657660
sessionChanged: bridge.resetTargets,
658661
},
659662
async () => (sessionId ? { foreground: 'background', sessionId } : { foreground: 'unknown' }),

‎packages/platform-apple/src/snapshot-route.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ export type SnapshotBridgeChannel<Target extends SnapshotBridgeRouteTarget> = Re
119119
/** Whether a resolver failure only says discovery is still running, so a capture may wait on it. */
120120
isDiscoveryPending?(error: unknown): boolean;
121121
refreshTarget?(device: DeviceInfo, appBundleId: string, signal: AbortSignal): Promise<Target>;
122-
observeOnlySupported?: boolean;
122+
/** Whether an observe-only capture may use this source; when not, it goes to the direct fallback. */
123+
observeOnlySupported: boolean;
123124
sessionChanged?(): void;
124125
}>;
125126

@@ -145,6 +146,7 @@ export function createAppleSnapshotRoute(
145146
source,
146147
resolveTarget,
147148
isDiscoveryPending: isSimulatorTargetDiscoveryPending,
149+
observeOnlySupported: true,
148150
},
149151
options.systemSurfaceForeground ?? createSystemSurfaceForegroundProbe(),
150152
);
@@ -508,7 +510,7 @@ function routeEligibility<Target extends SnapshotBridgeRouteTarget>(
508510
input: CaptureSnapshotInput,
509511
channel: SnapshotBridgeChannel<Target>,
510512
): 'bridge' | 'direct' | 'off-route' {
511-
if (input.options?.observeOnly && channel.observeOnlySupported === false) return 'direct';
513+
if (input.options?.observeOnly && !channel.observeOnlySupported) return 'direct';
512514
return hasSimulatorBridge(device) &&
513515
Boolean(input.options?.appBundleId) &&
514516
input.options?.customActions !== true &&

0 commit comments

Comments
 (0)