@@ -116,3 +116,91 @@ test('a name alias and overlapping Apple platform selectors are accepted', async
116116 await runCommand ( client , 'snapshot' , { device : 'ipad_pro' , platform : 'apple' } ) ;
117117 assert . equal ( requests . length , 1 ) ;
118118} ) ;
119+
120+ for ( const [ selector , input , conflict ] of [
121+ [
122+ { platform : 'ios' } ,
123+ { serial : 'emulator-5554' } ,
124+ { key : 'serial' , pinnedKey : 'platform' , pinned : 'ios' , requested : 'emulator-5554' } ,
125+ ] ,
126+ [
127+ { platform : 'android' } ,
128+ { udid : 'IPAD-001' } ,
129+ { key : 'udid' , pinnedKey : 'platform' , pinned : 'android' , requested : 'IPAD-001' } ,
130+ ] ,
131+ [
132+ { udid : 'IPAD-001' } ,
133+ { serial : 'emulator-5554' } ,
134+ { key : 'serial' , pinnedKey : 'udid' , pinned : 'IPAD-001' , requested : 'emulator-5554' } ,
135+ ] ,
136+ [
137+ { serial : 'emulator-5554' } ,
138+ { udid : 'IPAD-001' } ,
139+ { key : 'udid' , pinnedKey : 'serial' , pinned : 'emulator-5554' , requested : 'IPAD-001' } ,
140+ ] ,
141+ [
142+ { udid : 'IPAD-001' } ,
143+ { platform : 'android' } ,
144+ { key : 'platform' , pinnedKey : 'udid' , pinned : 'IPAD-001' , requested : 'android' } ,
145+ ] ,
146+ [
147+ { serial : 'emulator-5554' } ,
148+ { platform : 'ios' } ,
149+ { key : 'platform' , pinnedKey : 'serial' , pinned : 'emulator-5554' , requested : 'ios' } ,
150+ ] ,
151+ [
152+ { platform : 'linux' } ,
153+ { udid : 'IPAD-001' } ,
154+ { key : 'udid' , pinnedKey : 'platform' , pinned : 'linux' , requested : 'IPAD-001' } ,
155+ ] ,
156+ [
157+ { platform : 'web' } ,
158+ { serial : 'emulator-5554' } ,
159+ { key : 'serial' , pinnedKey : 'platform' , pinned : 'web' , requested : 'emulator-5554' } ,
160+ ] ,
161+ ] as const ) {
162+ test ( `a pin ${ JSON . stringify ( selector ) } rejects incompatible selector ${ JSON . stringify ( input ) } before transport` , async ( ) => {
163+ const { client, requests } = recordingClient ( { ...PIN , selector } ) ;
164+ await assert . rejects (
165+ runCommand ( client , 'snapshot' , input ) ,
166+ failsWithPinConflict ( { message : / c o n f l i c t s w i t h t h e d e v i c e p i n / , conflicts : [ conflict ] } ) ,
167+ ) ;
168+ assert . equal ( requests . length , 0 ) ;
169+ } ) ;
170+ }
171+
172+ test ( 'an incompatible selector in a batch step is rejected before any request is sent' , async ( ) => {
173+ const { client, requests } = recordingClient ( PIN ) ;
174+ await assert . rejects (
175+ runCommand ( client , 'batch' , {
176+ steps : [ { command : 'snapshot' , input : { serial : 'emulator-5554' } } ] ,
177+ } ) ,
178+ failsWithPinConflict ( {
179+ message : / ^ B a t c h s t e p 1 : s e r i a l / ,
180+ conflicts : [
181+ {
182+ key : 'serial' ,
183+ pinnedKey : 'platform' ,
184+ pinned : 'ios' ,
185+ requested : 'emulator-5554' ,
186+ step : 1 ,
187+ } ,
188+ ] ,
189+ } ) ,
190+ ) ;
191+ assert . equal ( requests . length , 0 ) ;
192+ } ) ;
193+
194+ for ( const [ platform , identity ] of [
195+ [ 'ios' , { udid : 'IPAD-001' } ] ,
196+ [ 'macos' , { udid : 'MAC-001' } ] ,
197+ [ 'android' , { serial : 'emulator-5554' } ] ,
198+ [ 'harmonyos' , { serial : 'HARMONY-001' } ] ,
199+ [ 'vega' , { serial : 'VEGA-001' } ] ,
200+ ] as const ) {
201+ test ( `a ${ platform } pin accepts a compatible identity selector` , async ( ) => {
202+ const { client, requests } = recordingClient ( { ...PIN , selector : { platform } } ) ;
203+ await runCommand ( client , 'snapshot' , identity ) ;
204+ assert . equal ( requests . length , 1 ) ;
205+ } ) ;
206+ }
0 commit comments