You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 52ab61e
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ios-runner): let a host deadline speak for nothing
A build the host killed at its own `buildTimeoutMs` arrives with no rule matched, and on a phone that
happens to report its developer image down the enrichment answered with the image: a build that never
finished cannot have been refused for want of device support, and the caller was sent to mount an
image while their real problem was a 15-minute budget (#2690 review). The device now speaks only where
nothing matched AND the host's deadline did not end the command. The build catch threads that fact the
way it already threads `startupRuleMatched` — its wrapper buries the exec error too deep to inspect —
and a failure that never passed through a catch is read with host-kit's `isCommandTimeoutError`, so the
install and launch steps are covered by the exec's own `timeoutMs`.
Two things the same catch was doing to the error it rebuilt: the cause is now passed through, so the
reader of a daemon log still reaches the command that died, and the plumbing keys — whether a row
matched, whether the deadline hit — are internal and stripped with the hoisted diagnostic meta, because
a caller already holds the verdict they produced rather than the machinery that reached it.
note: 'The corroborated pairing (#2683 review): a build that names no cause, on a phone core read directly as reporting its image down. Naming the image beats cache-recovery advice; the state also travels as details.developerDiskImage.',
"note: Using target 'AgentDeviceRunner' for build-for-testing\nbuilding project 'AgentDeviceRunner' toward destination 'Example iPhone'\nCompileSwiftFile normal (in target 'AgentDeviceRunner' from project 'AgentDeviceRunner')\n",
note: "The build the host killed at its own `buildTimeoutMs`, on a phone reporting its image down (#2690 review). A slow build and a build the device refuses are different facts, and the second one is not available from a command that never finished: the reason stays unclassified with cache-recovery advice, and the image state rides along as a detail only. The shape follows the exec layer's timeout error; the 15-minute budget and the partial log are ours, so no capture stands behind them.",
0 commit comments