You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 520f5d1
Browse filesBrowse the repository at this point in the historyBrowse files
fix(depgraph): tighten report assertions and empty-flag handling
Review findings on #3285:
- model.test.ts asserted the SCC/modularity summary lines with shape-only
regexes that accepted any count or score, so a CLI line inconsistent with
the JSON it was derived from still passed. Compare against the exact
payload values instead (planted a wrong modularity value to confirm the
test now fails without the fix).
- flagValue returned an empty string for `--out ""` / `--dominator-entry ""`
verbatim, which bypassed the `?? <default>` fallback (only nullish values
trigger it) and resolved --out to the current directory, crashing the
write with EISDIR instead of falling back like a missing value does. Fixed
at the shared helper, with a regression test for both flags (confirmed
both fail against the prior flagValue).
- README overstated dominatorSummary.bottlenecks as covering "every
reachable file"; the entry itself is excluded by construction.
- Clarified the ALL_EDGES doc comment: computeZoneSccSummary builds its own
value-only zone graph and never reads this constant, only
computeCohesionSummary does.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
0 commit comments