You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 51d5906
Browse filesBrowse the repository at this point in the historyBrowse files
fix(test): make the iOS simulator smoke lane's red/green signal meaningful (#2491) (#3336)
* test(ios): accept the disclosed runner fallback in the depth-frontier snapshot assertion (#3328)
The lane asserted a regular snapshot must not carry snapshotQuality at all,
but the product's contract is a disclosure, not an absence: the AX bridge
publishes no verdict, and the XCTest runner the route falls back to always
stamps its serving strategy. When the bridge probe circuit is open for the
app generation (a legitimate cold/loaded-host state), the runner-served
healthy 'tree' verdict made the lane red twice on main (runs 37145696803,
37459193672). The assertion now keys on the typed verdict: an absent
(bridge) or healthy verdict is accepted, a degraded 'recovered' or
'sparse' verdict still fails, never on the warning string.
* test(ios): re-issue a live-lane step whose typed verdict says observation was prevented (#2491)
The replay steps in the iOS smoke job run with --retries 2 while the
fixture-backed E2E step runs node --test with no retry layer, so one cold
runner restart inside one 10s wait fails the whole job. Seven of the last
ten main failures are this one class: a wait whose own error names
wait_capture_stalled, wait_runner_restart_exhausted, or
wait_readiness_exhausted and carries retriable: true — the product itself
says 'retry' on those verdicts.
The harness gains an opt-in per-step classifier; the iOS lane feeds it a
predicate keyed on that typed conjunction only (wire retriable AND the
wait taxonomy reason), never on error text. A re-attributed miss re-issues
the step once; a readable miss (target absent, deadline exhausted after a
readable capture, a wrong asserted value, a runner crash) stays a hard
failure. Steps that already own a miss policy (allowFailure/expectFailure)
are exempt so existing retry loops keep their semantics.
* test(ios): reject a snapshot quality state outside the declared vocabulary
The acquisition assertion only rejected 'sparse' and unexempt 'recovered', so a
verdict with any other state (renamed enum, diverged runner) fell through both
branches and certified depth facts off a tree the lane never classified. The
state set is now pinned to the kernel-declared SNAPSHOT_QUALITY_STATES, with a
negative test for states outside it.
capture({ ...(state===undefined ? {} : { state }),backend: 'tree'}),
87
+
'regular depth-1 snapshot',
88
+
),
89
+
/stateoutsidethedeclaredvocabulary/,
90
+
);
91
+
}
92
+
});
93
+
94
+
test('a capture that declares its hittability evidence missing is rejected',()=>{
95
+
assert.throws(
96
+
()=>
97
+
assertSimulatorSnapshotAcquisition(
98
+
{
99
+
json: {
100
+
success: true,
101
+
data: {
102
+
nodes: [{index: 0,depth: 0}],
103
+
warnings: [
104
+
'iOS snapshot acquisition does not provide hittability evidence; regular snapshots omit unverified hittability while raw snapshots preserve supplied facts.',
0 commit comments