Repository navigation
Commit 50fc6fc
committed
fix(apple-runner): name the lost reply when the status probe fails
A runner that dies mid-mutation drops the reply, and the status probe that
follows fails. The error that reaches the caller was then a bare transport
error (`fetch failed`, dispatched unknown), with no typed reason. #3074
requires a reason that names the lost reply, so this path now builds an
error with reason runner_reply_lost (the name the restart arm already uses)
and recovery status_probe_failed. The error keeps the transport message
and details, and the transport error as cause. The session is still
invalidated, and the command is still not resent.
ADR 0011 gap list: the row ios-runner.transport.written-then-lost proves
the rule behind canResendAfterRestart's mutating arm, not a production
route. Over the real transport the arm cannot be reached, because
mutations go through sendRunnerCommandOnce and only the connect loop
raises the restart trigger.
Tests:
- runner-command-recovery: a failing status probe now asserts reason
runner_reply_lost, recovery status_probe_failed, dispatched unknown, and
the transport error as cause.
- runner-recovery-wiring: press/fill whose runner dies mid-command (real
fake-runner transport) now also asserts reason runner_reply_lost.
Mutation: drop `reason: RUNNER_REPLY_LOST_REASON` from
buildStatusProbeFailedError -> all three fail.1 parent 4758d27 commit 50fc6fc
4 files changed
Lines changed: 46 additions & 4 deletions
File tree
- docs/adr
- packages/platform-apple/src/runner
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
198 | 203 | | |
199 | 204 | | |
200 | 205 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
| 142 | + | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
148 | 156 | | |
149 | 157 | | |
150 | 158 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| 254 | + | |
254 | 255 | | |
255 | 256 | | |
256 | 257 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
208 | 213 | | |
209 | 214 | | |
210 | 215 | | |
| |||
505 | 510 | | |
506 | 511 | | |
507 | 512 | | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
508 | 536 | | |
509 | 537 | | |
510 | 538 | | |
| |||
0 commit comments