You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4fa09b2
Browse filesBrowse the repository at this point in the historyBrowse files
fix: review follow-ups for #1558 (help text, test strength, docs)
- Give replay --save-script its own help text instead of the shared
open/close "arm on open, publish on close" description: replay's flag
arms an ADR 0012 repair transaction, a disjoint lifecycle. Adds
CommandSchema.flagDescriptionOverrides so a command can swap a shared
flag's usageDescription without duplicating the FlagDefinition entry
(which would have shown --save-script twice in `help replay`). Pinned
in src/cli/parser/__tests__/cli-help-command-usage.test.ts (open/close
keep the shared text unchanged; replay gets the new one).
- Strengthen the never-armed close --save-script regression test in
session-close-shutdown.test.ts: the fixture now carries real
cleanup-bearing state (an active iOS simulator recording, reusing
makeIosSimulatorRecordingSession/recordingKillMock) with spies proving
no teardown hook (recorder kill, runner stop) runs on the rejected
request, then that a follow-up plain close does tear it down. The
prior fixture had nothing for teardown to observably touch, so moving
the guard after stopBestEffortSessionResources would have passed it
silently. Also fixes a latent test-isolation leak this exposed: an
earlier test set a persistent mockStopIosRunnerSession rejection
(vi.clearAllMocks() clears call history, not implementations), which
would have poisoned any later Apple-platform close test; scoped it to
mockRejectedValueOnce.
- Point the migration guide (website/docs/docs/migrating-gestures.md) at
`open --save-script` → interact → `close` instead of the now-rejected
`open` → interact → `close --save-script`, matching the new guard and
the corrected help text.
_Generated by [Claude Code](https://claude.ai/code)_
Copy file name to clipboardExpand all lines: src/commands/replay/index.ts
+7Lines changed: 7 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -112,6 +112,13 @@ const replayCliSchema = {
112
112
'saveScript',
113
113
'force',
114
114
],
115
+
// ADR 0012 decision 6: on replay, --save-script arms a repair transaction from step 1 (not the
116
+
// open/close authoring lifecycle the shared flag description documents) and the healed script
117
+
// commits on that transaction's own teardown, not on a plain close.
118
+
flagDescriptionOverrides: {
119
+
saveScript:
120
+
'Arm a repair transaction from this replay (ADR 0012): recording starts at step 1, and the healed script commits when the repair-armed session tears down (close, close --save-script, or idle-reap). Independent of the open/close authoring arm-on-open. Optional custom output path.',
0 commit comments