Repository navigation
Commit 4c74a43
committed
fix(remote): load the lease beat only for the request that can use it
The extraction that moved the beat out of daemon-client.ts put it in cli.ts's
eager closure, which every command pays for, and took it from 295 modules to 296
(#2990's coverage failure). The beat is only ever useful to one kind of request:
one heading to a remote daemon that names a lease. Both guards are cheap and
local — the lease scope comes off the request the caller already built — so the
module now loads behind them and the closure is back to 295.
Also folds the beat's thin wrappers away from the entry surface, which is what
the four test-only exports in daemon-client.ts had become: createLeaseRenewalBeat
and leaseScopeForHeartbeat existed only for tests, the scope precedence they
pinned is already covered where it lives in contracts, and the one invariant that
wasn't covered anywhere — a beat per request id, so a timed-out beat cannot
cancel its successor — is now pinned over the real transport, where a shared id
is actually observable.1 parent b391a4a commit 4c74a43
2 files changed
Lines changed: 38 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
29 | | - | |
| 32 | + | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
| |||
62 | 66 | | |
63 | 67 | | |
64 | 68 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
69 | 74 | | |
70 | 75 | | |
71 | 76 | | |
| |||
285 | 290 | | |
286 | 291 | | |
287 | 292 | | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
0 commit comments