Skip to content

Commit 476fdfc

Browse files
committed
fix: keep Linux artifact gap honest
1 parent c596f8e commit 476fdfc

4 files changed

Lines changed: 11 additions & 26 deletions

File tree

‎test/integration/linux-e2e/command-evidence.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { PUBLIC_COMMANDS } from '../../../src/command-catalog.ts';
22

33
/** Commands exercised by the separate Linux/Xvfb command-evidence lane. */
44
export const LINUX_COMMAND_EVIDENCE_COMMANDS = [
5-
PUBLIC_COMMANDS.artifacts,
65
PUBLIC_COMMANDS.capabilities,
76
PUBLIC_COMMANDS.doctor,
87
PUBLIC_COMMANDS.events,

‎test/integration/linux-e2e/coverage-manifest.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,9 @@ const gap = (assertion: string): LinuxPlatformCoverageEntry => ({
9696
* work, not an implicit claim that a generic command works.
9797
*/
9898
export const LINUX_PLATFORM_COVERAGE = {
99-
[C.artifacts]: commandEvidenceLive('the command-evidence lane lists a live screenshot artifact'),
99+
[C.artifacts]: gap(
100+
'No Linux live command creates a downloadable daemon artifact for inventory yet',
101+
),
100102
[C.devices]: contract(
101103
LINUX_PROVIDER_EVIDENCE.path,
102104
LINUX_PROVIDER_EVIDENCE.test,

‎test/integration/linux-e2e/live-runner.ts‎

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
createLiveDeviceHarness,
1515
type LiveDeviceContext,
1616
} from '../live-device-e2e/runtime.ts';
17-
import { assertPngFile } from '../provider-scenarios/assertions.ts';
1817
import { runLiveReplayTestSuite } from '../live-device-e2e/replay-suite.ts';
1918
import { writeCoverageReport } from '../live-device-e2e/coverage.ts';
2019
import {
@@ -75,7 +74,7 @@ async function runLinuxCommandEvidence(): Promise<void> {
7574
async function runCommandEvidence(context: LinuxContext): Promise<void> {
7675
await runCommandDiscoveryEvidence(context);
7776
await runSnapshotEvidence(context);
78-
await runArtifactEvidence(context);
77+
await runEventEvidence(context);
7978
}
8079

8180
async function runCommandDiscoveryEvidence(context: LinuxContext): Promise<void> {
@@ -186,24 +185,7 @@ function assertLinuxBatchResults(json: any): void {
186185
assert.equal(second.command, 'snapshot', JSON.stringify(json));
187186
}
188187

189-
async function runArtifactEvidence(context: LinuxContext): Promise<void> {
190-
const screenshotPath = path.join(context.artifactDir, 'linux-command-evidence.png');
191-
await runStep(context, 'capture a Linux artifact for inventory', ['screenshot', screenshotPath]);
192-
assertPngFile(screenshotPath);
193-
194-
const artifacts = await runStep(context, 'list Linux session artifacts', ['artifacts']);
195-
const artifactEntries = artifacts.json?.data?.artifacts;
196-
assert.ok(Array.isArray(artifactEntries), JSON.stringify(artifacts.json));
197-
assert.ok(
198-
artifactEntries.some(
199-
(entry: Record<string, unknown>) =>
200-
entry.artifactType === 'screenshot' &&
201-
String(entry.path ?? entry.filename ?? '').includes(path.basename(screenshotPath)),
202-
),
203-
`Linux artifact inventory did not include the screenshot: ${JSON.stringify(artifacts.json)}`,
204-
);
205-
verifyCommand(context, C.artifacts, 'artifact inventory exposes the live screenshot');
206-
188+
async function runEventEvidence(context: LinuxContext): Promise<void> {
207189
const timeline = await collectPagedEventTimeline((cursor) => readLinuxEventPage(context, cursor));
208190
for (const command of [C.open, C.snapshot]) {
209191
assert.ok(

‎test/integration/smoke-linux-coverage.test.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,14 @@ test('Linux coverage exhaustively classifies the public catalog', () => {
4646
test('Linux coverage report has the expected classification counts', () => {
4747
assert.deepEqual(LINUX_PLATFORM_COVERAGE_CLASSIFICATION_SUMMARY, {
4848
// focus (#1925), click, and type remain live via the existing replay. The separate
49-
// command-evidence lane adds ten generic-command rows without changing that replay. Keyboard,
50-
// orientation, and tv-remote remain fact-owned command-contract rows, not catalog denials.
49+
// command-evidence lane adds nine generic-command rows without changing that replay. Artifact
50+
// inventory remains a gap because local Linux screenshot paths are not daemon-downloadable.
51+
// Keyboard, orientation, and tv-remote remain fact-owned command-contract rows, not catalog
52+
// denials.
5153
capabilityDenial: 7,
5254
contract: 21,
53-
gap: 8,
54-
live: 18,
55+
gap: 9,
56+
live: 17,
5557
total: 54,
5658
});
5759

0 commit comments

Comments
 (0)