Skip to content

Commit 457fafe

Browse files
committed
test: guard network parser placement
1 parent 1bdd382 commit 457fafe

2 files changed

Lines changed: 78 additions & 0 deletions

File tree

‎scripts/layering/contracts-implementation-policy.test.ts‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,38 @@ test('contracts policy ignores type vocabulary, prose, tests, and capture-kit me
3939
[],
4040
);
4141
});
42+
43+
test('network traffic vocabulary cannot grow parser implementation inside contracts', () => {
44+
assert.deepEqual(
45+
messages(
46+
[
47+
"import type { NetworkEntry } from './network-log.ts';",
48+
'export type NetworkDump = Readonly<{ entries: readonly NetworkEntry[] }>;',
49+
'export interface NetworkParserOptions { readonly maxEntries: number }',
50+
].join('\n'),
51+
'packages/contracts/src/network-traffic.ts',
52+
),
53+
[],
54+
);
55+
assert.match(
56+
messages(
57+
'export function readRecentNetworkTrafficFromText() { return []; }',
58+
'packages/contracts/src/network-traffic.ts',
59+
)[0]!,
60+
/runtime implementation/,
61+
);
62+
assert.match(
63+
messages(
64+
'export const parseNetworkTimestamp = (value: string) => value;',
65+
'packages/contracts/src/network-traffic-value.ts',
66+
)[0]!,
67+
/parser modules belong in @agent-device\/capture-kit/,
68+
);
69+
assert.deepEqual(
70+
messages(
71+
'export function readRecentNetworkTrafficFromText() { return []; }',
72+
'packages/capture-kit/src/network-traffic.ts',
73+
),
74+
[],
75+
);
76+
});

‎scripts/layering/contracts-implementation-policy.ts‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,12 @@ export function contractsImplementationAuthorityViolations(
2222
for (const file of sources) {
2323
if (!isContractsProduction(file.path)) continue;
2424
const parsed = parseSync(file.path, file.source);
25+
const networkTrafficViolation = networkTrafficImplementationViolation(
26+
file.path,
27+
file.source,
28+
parsed.program.body,
29+
);
30+
if (networkTrafficViolation) violations.push(networkTrafficViolation);
2531
for (const site of moduleSpecifiers(parsed.module, file.source)) {
2632
if (!FORBIDDEN_HOST_MODULES.test(site.spec)) continue;
2733
violations.push(
@@ -48,6 +54,43 @@ export function contractsImplementationAuthorityViolations(
4854
return violations;
4955
}
5056

57+
function networkTrafficImplementationViolation(
58+
file: string,
59+
source: string,
60+
body: readonly unknown[],
61+
): LayeringViolation | undefined {
62+
if (!file.startsWith('packages/contracts/src/network-traffic')) return undefined;
63+
if (file !== 'packages/contracts/src/network-traffic.ts') {
64+
return violation(
65+
file,
66+
1,
67+
'contracts may own only the neutral network-traffic vocabulary; parser modules belong in @agent-device/capture-kit',
68+
);
69+
}
70+
const implementation = body.find((statement) => !isTypeOnlyStatement(statement));
71+
if (!implementation || typeof implementation !== 'object') return undefined;
72+
return violation(
73+
file,
74+
lineAt(source, Number((implementation as Record<string, unknown>).start ?? 0)),
75+
'contracts network-traffic vocabulary contains runtime implementation; move parser mechanics to @agent-device/capture-kit',
76+
);
77+
}
78+
79+
function isTypeOnlyStatement(value: unknown): boolean {
80+
if (value === null || typeof value !== 'object') return false;
81+
const statement = value as Record<string, unknown>;
82+
if (statement.type === 'ImportDeclaration') return statement.importKind === 'type';
83+
if (statement.type === 'TSTypeAliasDeclaration' || statement.type === 'TSInterfaceDeclaration') {
84+
return true;
85+
}
86+
if (statement.type !== 'ExportNamedDeclaration') return false;
87+
if (statement.exportKind === 'type') return true;
88+
const declaration = statement.declaration as Record<string, unknown> | undefined;
89+
return (
90+
declaration?.type === 'TSTypeAliasDeclaration' || declaration?.type === 'TSInterfaceDeclaration'
91+
);
92+
}
93+
5194
function moduleSpecifiers(
5295
module: ReturnType<typeof parseSync>['module'],
5396
source: string,

0 commit comments

Comments
 (0)