Skip to content

Commit 410711c

Browse files
committed
chore(gates): ack the two upload digests the abort-reason fix moved
finalizeDirectUpload and streamFileToHttpRequestAttempt changed shape; both edits are client-side only — the bytes a protocol-2 daemon parses for an uncancelled request are unchanged, and a canceled request is the disconnect it already handles.
1 parent 39530e3 commit 410711c

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎test/wire-compat/ledger.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
"src/remote/upload-client.ts#UploadPreflightResponse": "sha256:196a1d9ef41a1aec192589fa7ccb30cf71d971a005349d5d73eed42e6ab21327",
162162
"src/remote/upload-client.ts#UploadPreflightResult": "sha256:bd8fc6d617c0630325455fd64d0fe319daaced198ee6745e4673a8ace3df460d",
163163
"src/remote/upload-client.ts#UploadResponse": "sha256:499e01466b5e0e03413f8d3f1986f5af6bc120704c50a3747d84de422b3f0314",
164-
"src/remote/upload-client.ts#finalizeDirectUpload": "sha256:04e18bdf91b9930a04d43f1661fe3f31ac2e6018154f8a8cb14656b9bc2b6140",
164+
"src/remote/upload-client.ts#finalizeDirectUpload": "sha256:5d283353df5f089a6ab26b7be96c44997e6b9905b329cb993d300c615479d715",
165165
"src/remote/upload-client.ts#isStringRecord": "sha256:b6d6b571b90baf0976d9c347c4a45a4363a4df5ad184ea1087cb3b9febd4b624",
166166
"src/remote/upload-client.ts#parseUploadPreflightResult": "sha256:7ce3f43b45c03df8b7f2690432beedc7a537c1bba540961716862f8a632d5623",
167167
"src/remote/upload-client.ts#requestUploadPreflight": "sha256:4c9863bce8757f1dc0f01ec7374019e752efc8e786cd070200f516a1d72d09e1",
@@ -178,7 +178,7 @@
178178
"src/remote/upload-stream.ts#parseNonNegativeIntegerHeader": "sha256:5cbe9c6994459d673d988a51407e65556e28175b187ce0a9d27cbb6331962834",
179179
"src/remote/upload-stream.ts#parseUploadResumeOffset": "sha256:297184ea22a6dc1cda9aee17034122ae0ea2f43d0355647f6fcf02f3f4b5ca0e",
180180
"src/remote/upload-stream.ts#streamFileToHttpRequest": "sha256:ce07ea33a275e06e4cceaf0c75a079bd0c7938f36df6817407dbb1cc8c4ff900",
181-
"src/remote/upload-stream.ts#streamFileToHttpRequestAttempt": "sha256:bc636083b00c2eef73a65a3446491e831510cdf934ff2545dd12e6b6ba13160d"
181+
"src/remote/upload-stream.ts#streamFileToHttpRequestAttempt": "sha256:aa73fb51890ca5e43d4aa80c1d2124b574568380a73b19eae7da0ee3e3e7acf8"
182182
},
183183
"compatibleChanges": [
184184
{
@@ -318,8 +318,8 @@
318318
},
319319
{
320320
"declaration": "src/remote/upload-client.ts#finalizeDirectUpload",
321-
"digest": "sha256:04e18bdf91b9930a04d43f1661fe3f31ac2e6018154f8a8cb14656b9bc2b6140",
322-
"rationale": "#2946 adds the caller's abort signal to finalize's existing timeout. Route and body keys are unchanged, so a protocol-2 daemon parses an uncancelled finalize exactly as before."
321+
"digest": "sha256:5d283353df5f089a6ab26b7be96c44997e6b9905b329cb993d300c615479d715",
322+
"rationale": "#2946 adds the caller's abort signal to finalize's existing timeout and lets a canceled one reject with the signal's own reason instead of a wrapped transport error. Route and body keys are unchanged, so a protocol-2 daemon parses an uncancelled finalize exactly as before."
323323
},
324324
{
325325
"declaration": "src/remote/upload-client.ts#uploadLegacyArtifact",
@@ -333,8 +333,8 @@
333333
},
334334
{
335335
"declaration": "src/remote/upload-stream.ts#streamFileToHttpRequestAttempt",
336-
"digest": "sha256:bc636083b00c2eef73a65a3446491e831510cdf934ff2545dd12e6b6ba13160d",
337-
"rationale": "#2946 passes the optional abort signal to the request. The released 308 resume contract is untouched: offset headers, resume start offsets, redirects, and payload bytes are computed exactly as before."
336+
"digest": "sha256:aa73fb51890ca5e43d4aa80c1d2124b574568380a73b19eae7da0ee3e3e7acf8",
337+
"rationale": "#2946 passes the optional abort signal to the request and rejects with that signal's reason when it is what ended the stream. The released 308 resume contract is untouched: offset headers, resume start offsets, redirects, and payload bytes are computed exactly as before."
338338
}
339339
]
340340
}

0 commit comments

Comments
 (0)