You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3f02d56
Browse filesBrowse the repository at this point in the historyBrowse files
fix(doctor): scope the node-modules probe to a local source checkout
The probe ran unconditionally from findProjectRoot(), so it fired in two
contexts it cannot diagnose:
- Packaged installs. Published packages ship neither pnpm-lock.yaml (not
in the package.json `files` allowlist) nor an installed snapshot, so
every end user's `doctor` gained a spurious node-modules line and a
degraded overall status.
- `--remote`, where the daemon's own root describes the server
deployment rather than the caller's worktree, so the answer could not
address #1963 at all.
Whether a root is a source checkout is now decided by the presence of
pnpm-lock.yaml itself rather than a heuristic about install location, and
'no-source-checkout' is a distinct result rather than a warning, so the
packaged case cannot be represented as a defect. The probe returns
undefined there and the route appends no check, matching how doctor
already models an out-of-scope question (the device family is likewise
absent under --remote). The fresh-worktree catch is preserved: a lockfile
with no installed snapshot is still a hard failure.
The check:affected preflight is unchanged in behavior.
Route-level assertions cover all three contexts (source, packaged,
remote); each was verified to fail against the pre-fix wiring.
0 commit comments