Repository navigation
Commit 38852c1
committed
docs(coverage): name the deletion-only edit in the CRAP gate's wording
The paragraph said a deletion's raised score waits in the `--all` backlog, and
read the way the reviewer did: only added lines are charged, so a deletion is
never. That holds for a deletion-only edit and for a mixed one whose added lines
stay outside the function -- `run.test.ts` pins exactly that mixed case, adding
below `score` while deleting inside it, and the run is green. It does not hold
for added lines inside the function, which is charged the post-deletion score.
Names both halves so the conditional is visible rather than inferred from
"Adding lines is what charges a function", per the reviewer's optional wording
on #3501. Kept the mixed-edit clause because dropping it would overstate the
exemption the same paragraph is there to bound.1 parent 6083b1d commit 38852c1
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
262 | 263 | | |
263 | 264 | | |
264 | 265 | | |
| |||
0 commit comments