You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3678353
Browse filesBrowse the repository at this point in the historyBrowse files
fix(host-kit): one group-signal seam, and no deadline an app-log tail will not honour
`killProcessTree` probed a group with `process.kill(-pid, 0)` and then wrote to it by hand, so
host-kit had two group-signal paths and the one every runner-tree kill already used was the one
this file could not mock. The probe also decided nothing: EPERM made it report the group
reachable and the following write was refused all the same. It is gone, and the detached branch
is one call to `signalProcessGroupBestEffort`.
That seam now lives in `exec.ts`, below the module that already reached it. `host-process.ts`
imports `exec.ts` for `runCmd`, so importing its signal helper back up would close a production
value-import cycle, which `check:layering` R4 rejects outright; and giving the two of them a new
shared module below both is a module every one of those entries starts evaluating, which the
eager-closure budgets reject. `@agent-device/host-kit/process` exports the same name from the new
home, and nothing outside host-kit noticed.
Two tests moved with the function. The two group-kill tests now answer writes at a guard which
records what the kill aimed at and refuses to deliver it — the seam the hermetic signal setup
points real kill paths at — and a source-shape test fails if a second `process.kill(-…)` ever
appears in this module beside the seam. Reverting the detached branch to a raw group write turns
that one red.
`AppLogProcessCommand`'s host variant takes `Omit<HostCommandRequest, 'timeoutMs'>`. The
background exec it feeds passes `allowFailure`, `cwd`, and `env` and cannot pass a timeout, so a
producer that wrote one was writing a budget that never fires.
Co-authored-by: Apex by Callstack <[email protected]>
0 commit comments