Repository navigation
Commit 342248f
committed
fix(contracts): refuse to measure keyboard geometry that arrived rotated
Verified on iPhone 17 Pro with the landscape keyboard up: the screenshot shows the keyboard
full width across the bottom 327 pt of an 874 x 402 viewport, and both the regular and the
interactive projection report the key plane as 162 x 327 with the QWERTY columns running down
the short axis and the dock's globe button at y 8. iOS hands over the landscape keyboard's
rects in the keyboard's own rotated space, so a band derived from them would cover a 141 pt
strip on the left edge from y 77 down — refusing a headline the keyboard is nowhere near
while letting a tab-bar item at (264, 360) tap straight through into a key.
A docked keyboard is wide in both orientations, 402 x 233 in measured portrait and 874 x 327
in measured landscape, so geometry that comes back taller than it is wide is refused
measurement and the tap fails open, which is the same stance an unresolvable viewport gets.
Landscape coverage is not lost, only iOS's rotated read of it: the table now pins the
measured rotated tree as `undetermined` and pins a wide, docked landscape keyboard as
measurable against the landscape viewport's own bottom edge.
Recording the misfire rather than hiding it: `#2589`'s silent tap-into-a-key stays open on
landscape iOS until the Apple capture reports keyboard rects in the app's orientation space.
That is a capture-side fix, not a classifier rule, and gets its own issue.1 parent 6e13b1c commit 342248f
2 files changed
Lines changed: 100 additions & 25 deletions
File tree
- contracts/fixtures
- packages/contracts/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
1318 | 1318 | | |
1319 | 1319 | | |
1320 | 1320 | | |
1321 | | - | |
| 1321 | + | |
1322 | 1322 | | |
1323 | 1323 | | |
1324 | 1324 | | |
| |||
1343 | 1343 | | |
1344 | 1344 | | |
1345 | 1345 | | |
1346 | | - | |
| 1346 | + | |
1347 | 1347 | | |
1348 | | - | |
| 1348 | + | |
1349 | 1349 | | |
1350 | 1350 | | |
1351 | 1351 | | |
1352 | 1352 | | |
1353 | 1353 | | |
1354 | | - | |
| 1354 | + | |
1355 | 1355 | | |
1356 | 1356 | | |
1357 | | - | |
1358 | | - | |
1359 | | - | |
1360 | | - | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
1361 | 1361 | | |
1362 | 1362 | | |
1363 | 1363 | | |
1364 | 1364 | | |
1365 | | - | |
1366 | | - | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
| 1373 | + | |
| 1374 | + | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
1367 | 1380 | | |
1368 | 1381 | | |
1369 | 1382 | | |
| |||
1373 | 1386 | | |
1374 | 1387 | | |
1375 | 1388 | | |
1376 | | - | |
| 1389 | + | |
1377 | 1390 | | |
1378 | | - | |
1379 | | - | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
1380 | 1394 | | |
1381 | 1395 | | |
1382 | 1396 | | |
| |||
1385 | 1399 | | |
1386 | 1400 | | |
1387 | 1401 | | |
1388 | | - | |
| 1402 | + | |
1389 | 1403 | | |
1390 | | - | |
1391 | | - | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
1392 | 1407 | | |
1393 | | - | |
1394 | | - | |
1395 | | - | |
1396 | | - | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
1397 | 1412 | | |
1398 | 1413 | | |
1399 | 1414 | | |
1400 | 1415 | | |
1401 | 1416 | | |
1402 | 1417 | | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
1403 | 1469 | | |
1404 | 1470 | | |
1405 | 1471 | | |
1406 | | - | |
1407 | | - | |
1408 | | - | |
1409 | | - | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
1410 | 1476 | | |
1411 | 1477 | | |
1412 | 1478 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
190 | 199 | | |
191 | 200 | | |
192 | 201 | | |
| |||
0 commit comments