Skip to content

Commit 327a216

Browse files
thymikeeclaude
andcommitted
docs(revyl): point a released open at open, and state the 370 s ceiling
The `provider-lease-releasing` hint now names `open`, as the guide does, since `connect` rents nothing. The guide states that an `open` with no deadline stops waiting after 370 s, and Revyl's instance wrapper keeps the reason its principal is digested. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent e40a616 commit 327a216

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎packages/provider-revyl/src/revyl-session.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ import type {
1818
/** How long Revyl may take to assign a worker and connect the device before the start is given up on. */
1919
const READY_TIMEOUT_MS = 240_000;
2020
/**
21-
* Covers the time between `start_device` answering and readiness starting its own clock, and timer
22-
* jitter, so the lease table's cap never cuts readiness that Revyl still allows. Readiness clamps every
23-
* poll and sleep to its own deadline, so no poll interval needs room here.
21+
* Covers the gap between `start_device` answering and readiness starting its clock, plus timer jitter.
22+
* Readiness clamps every poll and sleep to its own deadline, so no poll interval needs room here.
2423
*/
2524
const READY_ANSWER_MARGIN_MS = 10_000;
2625
/** The longest one allocation may take: `start_device`'s own answer budget, then readiness. */

‎packages/provider-revyl/src/runtime-instance.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { REVYL_PROVIDER } from './device.ts';
33
import { REVYL_DEFAULT_BACKEND_URL, resolveRevylBackendUrl } from './revyl-client.ts';
44

55
/**
6-
* The stable identity of one Revyl runtime, and so of one owner. Two runtimes that rent devices for
7-
* the same account against the same origin share it; two accounts never do.
6+
* The stable identity of one Revyl runtime, and so of one owner: one per account and origin. The
7+
* instance travels into diagnostics, so `providerRuntimeInstance` digests the principal, never carries it.
88
*/
99
export function resolveRevylRuntimeInstance(
1010
options: Readonly<{

‎packages/provider-revyl/src/runtime.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ function createRevylLeaseDriver(
249249
new AppError('COMMAND_FAILED', `Revyl lease ${lease.leaseId} is being released.`, {
250250
reason: 'provider-lease-releasing',
251251
leaseId: lease.leaseId,
252-
hint: 'Connect again to rent a device under a new lease.',
252+
hint: 'Run open again; it allocates a new lease and rents a fresh device.',
253253
}),
254254
gaveUp: (lease, caller, budgetMs, rented) =>
255255
revylCallerGaveUp(

‎website/docs/docs/revyl.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,4 +174,5 @@ takes when the daemon loads the plugin from the plugin store.
174174
- A device that Revyl released while your session was open reports `provider-session-gone`. Run
175175
`close` and `open` again to rent a fresh one.
176176
- An `open` still waiting for its device when its lease is released reports `provider-lease-releasing`.
177-
That lease is ending; run `open` again, which allocates a new lease and rents a fresh device.
177+
That lease is ending; run `open` again, which allocates a new lease and rents a fresh device. An
178+
`open` that names no deadline stops waiting for a device after 370 s.

0 commit comments

Comments
 (0)