Repository navigation
Commit 325dd4d
committed
ci(macos): run the darwin-only Vitest files on a lane that reaches them
`.github/workflows/macos.yml:168` is the only Vitest invocation in the repository that
runs on macOS. It was a hand-written two-file list, so a test guarded on
`process.platform === 'darwin'` had no lane that could execute it: the sole job that
collects `packages/*/src/**/*.test.ts` is the `unit-ci` gate on `ubuntu-latest`, where
the whole file skips.
Two files were dying that way, six tests between them:
- `packages/platform-apple/src/foldable/simulator-hid-native.test.ts` — the only consumer
of the `samples` column of `contracts/fixtures/fold-keyframes.json`. The ObjC
interpolation in `apple/fold-helper/Fold.m` is the thing those samples check, and the
TypeScript twin (`device-rotation-fold-input.test.ts`) reads only `valid` and
`keyframesJson`. Proven: nudging one `angle` from 160 to 163 reddens this file
("opening reversal at 1667ms") while the TS legs that Linux CI actually runs report
14 passed. The column was unguarded on every lane.
- `packages/capture-kit/src/recording/__tests__/recording-scripts.test.ts` — `swiftc
-typecheck` over `apple/runner/AgentDeviceRunner/RecordingScripts`.
Both join the existing conditional step rather than a new unconditional one, because
`selectAppleBridgeProof` (`scripts/apple-ci-impact.ts:43`) already fires on any change
under `apple/` or `packages/platform-apple/src/` — which is exactly the input set of both
tests — so they run when their subject moved and cost nothing when it did not. The step is
renamed to say what it now covers. All four files pass together here: 58 tests.
One gap left on purpose: editing the recording-scripts test file alone does not trigger the
step, since `packages/capture-kit/` is outside the classifier's prefixes. Widening
`selectAppleBridgeProof` is affected-check model territory with its own tests, not a
workflow edit; noted rather than folded in.1 parent 6428c54 commit 325dd4d
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
171 | 173 | | |
172 | 174 | | |
173 | 175 | | |
| |||
0 commit comments