Skip to content

Commit 31cb436

Browse files
committed
docs: fix two self-review findings on #3723
- pull-requests.md: "This is not a pass" had an unclear referent after the split; name the blocker. - CONTRIBUTING.md: restore the base qualifier "a normal code change"; broad refactors use `pnpm check`.
1 parent cbd2120 commit 31cb436

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@ pnpm test:maestro-compat # example of a focused family suite
201201
pnpm exec vitest run path/to/file.test.ts
202202
```
203203

204-
Before pushing, commit the change and validate that exact commit. The repository derives the
205-
required gates from the diff:
204+
Before pushing a normal code change, commit it and validate that exact commit. The repository
205+
derives the required gates from the diff:
206206

207207
```bash
208208
pnpm check:affected --run --head "$(git rev-parse HEAD)"

‎docs/agents/pull-requests.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Follow [validation](testing.md).
1515
Record the `check:affected --run --head` receipt in the PR body. A serialized gate stage can validate the pushed head instead.
1616
Before you report publication, record that result.
1717
For unresolved failures, follow the blocked-validation table.
18-
An authorized incomplete draft can record a blocker. This is not a pass.
18+
An authorized incomplete draft can record a blocker. A blocker is not a pass.
1919
Push once per review round. Each push restarts CI. Drafts skip device lanes.
2020

2121
For device-facing changes, follow [device verification](device-verification.md).

0 commit comments

Comments
 (0)