Skip to content

Commit 3105851

Browse files
thymikeeclaude
andcommitted
docs(interaction): describe the removal without overstating single resolution
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 20fb8a6 commit 3105851

6 files changed

Lines changed: 10 additions & 7 deletions

File tree

‎packages/selectors/src/selector-pipeline-policy.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export type SelectorPipelinePolicy = SelectorListPolicy & {
107107
const WAIT_POLL_BUDGET: WaitPollBudget = { defaultTimeoutMs: 10_000, intervalMs: 300 };
108108

109109
export const SELECTOR_PIPELINE_POLICIES = {
110-
/** `click`/`press`/`longpress`: the tap lands on the actionable owner of the match. */
110+
/** `click`/`press`/`longpress`: the action dispatches to the actionable owner of the match. */
111111
promotedTarget: {
112112
resolution: SELECTOR_RESOLUTION_POLICIES.act,
113113
occlusion: 'exclude-and-refuse',

‎src/commands/interaction/runtime/__tests__/test-utils/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ export function createInteractionDevice(
357357
> & {
358358
platform?: AgentDeviceBackend['platform'];
359359
sessionMetadata?: Record<string, unknown>;
360-
/** An advancing clock for wait and post-action observation loops. */
360+
/** An advancing clock for wait, post-action observation, and moving-target recheck loops. */
361361
clock?: { now: () => number; sleep: (ms: number) => Promise<void> };
362362
} = {},
363363
) {

‎src/commands/interaction/runtime/interaction-snapshot-capture.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import { now, toBackendContext } from '../../runtime-common.ts';
66
/**
77
* A leaf shared by every interaction runtime module that needs a fresh (or session-cached) tree:
88
* `resolution.ts`'s ref/selector resolution, `selector-target-resolution.ts`'s acting selector lookup,
9-
* `gestures.ts`'s viewport resolution, and `post-action-observation.ts`'s `--verify` baseline.
9+
* `moving-target-gate.ts`'s re-observation, `gestures.ts`'s viewport resolution, and
10+
* `post-action-observation.ts`'s `--verify` baseline.
1011
* Deliberately self-contained — it imports no sibling of this directory, so those siblings can
1112
* import it without ever risking a cycle back.
1213
*/

‎test/integration/provider-scenarios/press-selector-resolution.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,9 @@ test('press refuses a selector miss after one interactive and full capture attem
120120
const callsBeforePress = transcript.calls.length;
121121
const press = await daemon.callCommand('press', ['label=Continue']);
122122
const error = assertRpcError(press, 'COMMAND_FAILED', /Selector did not match/);
123-
const details = error.details as { reason: unknown };
123+
const details = error.details as { reason: unknown; dispatched?: unknown };
124124
assert.equal(details.reason, 'selector_not_found');
125+
assert.equal(details.dispatched, 'no');
125126

126127
const commands = transcript.calls.slice(callsBeforePress).map((call) => call.command);
127128
assert.deepEqual(commands, ['ios.runner.snapshot', 'ios.runner.snapshot']);

‎website/docs/docs/client-api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ await client.command.fold({
207207

208208
`fold` accepts either `pose` or `keyframes`. Keyframes use linear interpolation at roughly 60 updates per second; repeat an angle to hold it. Timestamps must start at zero and increase strictly, with 2–64 frames and a final timestamp no greater than 60,000ms. Angles must be finite and between 0° and 180°. The final timestamp bounds motion, excluding helper preparation and final hinge verification. A custom final angle is verified within 0.5°; interior angles must also settle. Cancellation stops the motion at its current angle. Re-snapshot afterwards, including after interrupted motion. Android emulators accept `pose` only.
209209

210-
`press`, `click`, and `longpress` resolve their target once. When a screen is still loading, wait for its landmark before interacting:
210+
`press`, `click`, and `longpress` do not wait for a missing target to appear. When a screen is still loading, wait for its landmark before interacting:
211211

212212
```ts
213213
await client.command.wait({ text: 'Continue', timeoutMs: 5_000 });

‎website/docs/docs/replay-e2e.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@ agent-device replay ~/.agent-device/sessions/e2e-2026-02-09T12-00-00-000Z.ad --s
9191

9292
Earlier `close` actions still run. `test` does not accept the flag because each suite attempt
9393
cleans up its own session.
94-
- `press`, `click`, and `longpress` steps resolve their target once. If a screen needs time to
95-
load, add an explicit wait before the interaction, such as `wait 'label="Continue"' 5000`.
94+
- `press`, `click`, and `longpress` steps do not wait for a missing target to appear. If a screen
95+
needs time to load, add an explicit wait before the interaction, such as
96+
`wait 'label="Continue"' 5000`.
9697
Covered, off-screen, and ambiguous targets fail as they do in live commands.
9798
- When the target is missing, replay stops with `REPLAY_DIVERGENCE`.
9899
For a step recorded with a target annotation (the `# agent-device:target-v1`

0 commit comments

Comments
 (0)