You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2dd629d
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(daemon): migrate script publication onto the tagged aggregate (#1478 P4a)
The eight co-resident SessionState fields (scriptRecordingState, saveScriptPath,
saveScriptForce, saveScriptBoundary, saveScriptComplete, saveScriptCommitted,
repairPlatformCloseReceipt, repairSourcePath) are gone; SessionState.scriptPublication
holds the aggregate, and every writer migrated in this commit — no shadow state.
Two daemon-private projections own the writes, enforced by the R7 ownership gate:
- session-replay-transaction.ts (ReplaySessionTransaction): repair arm/demote/
complete/abort, close receipts, and the uncommitted/boundary/sourcePath reads
that idle-reap, tombstones, divergence-hold, and the recorder's exclusion key off.
- session-script-publication-capability.ts (SessionScriptPublication): authoring
arm on open, the recorded --save-script flag ingress, active publication, the
published transitions, and the effective per-target force decision (#1258).
The writer keeps the commit transition so idempotence stays colocated with the
atomic publish.
Failure/retry transitions pinned as the brief requires: platform-close failure
leaves state unchanged (no receipt, retry re-dispatches); publication failure
retains target+force+receipt (same-identity retry skips close dispatch); committed
and aborted are explicit terminal states that drop the receipt.
Design decisions resolved:
- Force retention across a default->explicit retarget is preserved as-is and
still flagged in resolveScriptTarget's docblock as a probable #1258 gap;
tightening it stays a separate product change.
- The never-armed 'close --save-script' whole-log publication folds into the
authoring lifecycle (armed at the recorded close, published in the same
request) instead of a fourth variant: every close path that reaches the write
deletes the session, so the transient armed state cannot leak into
'session save-script' eligibility, whose not-armed-before-this-journey
rejection is untouched.
One real bug caught by the migrated tests and fixed in resolveScriptTarget: a
bare (pathless) re-arm collapsed an already-materialized explicit target back to
the daemon default, wiping the healed-sibling path on every per-step repair
re-arm and defeating the persisted-force preflight bypass. A bare re-arm now
keeps the previous target and only adds a live force grant.
R7 rows consolidated to one scriptPublication entry (three owners) and the
recordSession row narrowed; the R10 baseline drops to 22 writer-owned fields /
28 owner claims so the consolidation cannot regrow.
Gates: typecheck, lint, format, layering clean; 624 files / 5220 tests pass
(two known contention-flake timeouts reproduce only under full-suite load and
pass in isolation).
Refs #1478
Co-Authored-By: Claude <[email protected]>
0 commit comments