|
| 1 | +import assert from 'node:assert/strict'; |
| 2 | +import crypto from 'node:crypto'; |
| 3 | +import fs from 'node:fs'; |
| 4 | +import path from 'node:path'; |
| 5 | +import { test, vi } from 'vitest'; |
| 6 | +import { readCurrentOwnerIdentity } from '@agent-device/host-kit/process'; |
| 7 | +import { createDurableResourceEnvelope } from '@agent-device/capture-kit'; |
| 8 | +import { localRuntimeOwner } from '@agent-device/contracts/platform-runtime'; |
| 9 | +import { appLogResourceStore } from '../daemon/app-log-resource-store.ts'; |
| 10 | +import { runStaleDeviceClaimRelease } from '../cli/commands/device-release.ts'; |
| 11 | +import { runCliCapture } from './cli-capture.ts'; |
| 12 | +import { mkdtempForTestSync } from './test-utils/tmp-dir.ts'; |
| 13 | + |
| 14 | +vi.mock('@agent-device/host-kit/process', async (importOriginal) => |
| 15 | + (await import('./test-utils/host-process-mock.ts')).pinOwnProcessStartTime(importOriginal), |
| 16 | +); |
| 17 | + |
| 18 | +function hashedClaimPath(claimsDir: string, deviceKey: string): string { |
| 19 | + const hash = crypto.createHash('sha256').update(deviceKey).digest('hex'); |
| 20 | + return path.join(claimsDir, `${hash}.json`); |
| 21 | +} |
| 22 | + |
| 23 | +function writeClaim( |
| 24 | + claimsDir: string, |
| 25 | + params: { |
| 26 | + deviceKey: string; |
| 27 | + id: string; |
| 28 | + name: string; |
| 29 | + session: string; |
| 30 | + ownerPid: number; |
| 31 | + ownerStartTime: string | null; |
| 32 | + stateDir: string; |
| 33 | + }, |
| 34 | +): void { |
| 35 | + fs.writeFileSync( |
| 36 | + hashedClaimPath(claimsDir, params.deviceKey), |
| 37 | + JSON.stringify({ |
| 38 | + schemaVersion: 1, |
| 39 | + deviceKey: params.deviceKey, |
| 40 | + device: { platform: 'android', id: params.id, name: params.name, kind: 'emulator' }, |
| 41 | + session: params.session, |
| 42 | + workspace: '/worktrees/release-test', |
| 43 | + stateDir: params.stateDir, |
| 44 | + ownerPid: params.ownerPid, |
| 45 | + ownerStartTime: params.ownerStartTime, |
| 46 | + ownerToken: `${params.session}-token`, |
| 47 | + createdAtMs: 1, |
| 48 | + updatedAtMs: 1, |
| 49 | + }), |
| 50 | + ); |
| 51 | +} |
| 52 | + |
| 53 | +test('device release requires --stale and explains how live owners are released', async () => { |
| 54 | + const result = await runCliCapture(['device', 'release', '--json']); |
| 55 | + assert.equal(result.calls.length, 0); |
| 56 | + const payload = JSON.parse(result.stdout || result.stderr); |
| 57 | + assert.equal(payload.success, false); |
| 58 | + assert.equal(payload.error.code, 'INVALID_ARGS'); |
| 59 | + assert.match(payload.error.message, /pass --stale to confirm/); |
| 60 | +}); |
| 61 | + |
| 62 | +test('device release --stale settles a provably dead owner daemonlessly and refuses a live one', async () => { |
| 63 | + const claimsDir = mkdtempForTestSync('agent-device-cli-release-'); |
| 64 | + const stateDir = mkdtempForTestSync('agent-device-cli-release-state-'); |
| 65 | + const owner = readCurrentOwnerIdentity(); |
| 66 | + try { |
| 67 | + writeClaim(claimsDir, { |
| 68 | + deviceKey: 'local:android:none:emulator-5554', |
| 69 | + id: 'emulator-5554', |
| 70 | + name: 'Dead Pixel', |
| 71 | + session: 'dead-session', |
| 72 | + ownerPid: 999_999_999, |
| 73 | + ownerStartTime: 'old-start-time', |
| 74 | + stateDir, |
| 75 | + }); |
| 76 | + writeClaim(claimsDir, { |
| 77 | + deviceKey: 'local:android:none:emulator-5556', |
| 78 | + id: 'emulator-5556', |
| 79 | + name: 'Live Pixel', |
| 80 | + session: 'live-session', |
| 81 | + ownerPid: owner.pid, |
| 82 | + ownerStartTime: owner.startTime, |
| 83 | + stateDir: process.cwd(), |
| 84 | + }); |
| 85 | + |
| 86 | + const result = await runCliCapture(['device', 'release', '--stale', '--json'], { |
| 87 | + env: { AGENT_DEVICE_CLAIMS_DIR: claimsDir }, |
| 88 | + }); |
| 89 | + assert.equal(result.calls.length, 0); |
| 90 | + const payload = JSON.parse(result.stdout); |
| 91 | + assert.equal(payload.success, true); |
| 92 | + assert.equal(payload.data.released.length, 1); |
| 93 | + assert.equal(payload.data.released[0].session, 'dead-session'); |
| 94 | + assert.equal(payload.data.refused.length, 1); |
| 95 | + assert.equal(payload.data.refused[0].session, 'live-session'); |
| 96 | + assert.equal(payload.data.refused[0].reason, 'live-owner'); |
| 97 | + assert.equal( |
| 98 | + fs.existsSync(hashedClaimPath(claimsDir, 'local:android:none:emulator-5554')), |
| 99 | + false, |
| 100 | + ); |
| 101 | + assert.equal( |
| 102 | + fs.existsSync(hashedClaimPath(claimsDir, 'local:android:none:emulator-5556')), |
| 103 | + true, |
| 104 | + ); |
| 105 | + } finally { |
| 106 | + fs.rmSync(claimsDir, { recursive: true, force: true }); |
| 107 | + fs.rmSync(stateDir, { recursive: true, force: true }); |
| 108 | + } |
| 109 | +}); |
| 110 | + |
| 111 | +test('device status --stale offers the exact release command for provably dead owners', async () => { |
| 112 | + const claimsDir = mkdtempForTestSync('agent-device-cli-release-'); |
| 113 | + try { |
| 114 | + writeClaim(claimsDir, { |
| 115 | + deviceKey: 'local:android:none:emulator-5554', |
| 116 | + id: 'emulator-5554', |
| 117 | + name: 'Dead Pixel', |
| 118 | + session: 'dead-session', |
| 119 | + ownerPid: 999_999_999, |
| 120 | + ownerStartTime: 'old-start-time', |
| 121 | + stateDir: process.cwd(), |
| 122 | + }); |
| 123 | + |
| 124 | + const result = await runCliCapture(['device', 'status', '--stale'], { |
| 125 | + env: { AGENT_DEVICE_CLAIMS_DIR: claimsDir }, |
| 126 | + }); |
| 127 | + assert.match( |
| 128 | + result.stdout, |
| 129 | + /Release provably dead owners with: agent-device device release --stale/, |
| 130 | + ); |
| 131 | + } finally { |
| 132 | + fs.rmSync(claimsDir, { recursive: true, force: true }); |
| 133 | + } |
| 134 | +}); |
| 135 | + |
| 136 | +test('device release --stale renders per-claim outcomes with a live-owner hint in text mode', async () => { |
| 137 | + const claimsDir = mkdtempForTestSync('agent-device-cli-release-'); |
| 138 | + const stateDir = mkdtempForTestSync('agent-device-cli-release-state-'); |
| 139 | + const owner = readCurrentOwnerIdentity(); |
| 140 | + try { |
| 141 | + writeClaim(claimsDir, { |
| 142 | + deviceKey: 'local:android:none:emulator-5554', |
| 143 | + id: 'emulator-5554', |
| 144 | + name: 'Dead Pixel', |
| 145 | + session: 'dead-session', |
| 146 | + ownerPid: 999_999_999, |
| 147 | + ownerStartTime: 'old-start-time', |
| 148 | + stateDir, |
| 149 | + }); |
| 150 | + writeClaim(claimsDir, { |
| 151 | + deviceKey: 'local:android:none:emulator-5556', |
| 152 | + id: 'emulator-5556', |
| 153 | + name: 'Live Pixel', |
| 154 | + session: 'live-session', |
| 155 | + ownerPid: owner.pid, |
| 156 | + ownerStartTime: owner.startTime, |
| 157 | + stateDir: process.cwd(), |
| 158 | + }); |
| 159 | + |
| 160 | + const result = await runCliCapture(['device', 'release', '--stale'], { |
| 161 | + env: { AGENT_DEVICE_CLAIMS_DIR: claimsDir }, |
| 162 | + }); |
| 163 | + assert.match(result.stdout, /released android Dead Pixel session=dead-session/); |
| 164 | + assert.match(result.stdout, /refused android Live Pixel session=live-session[^\n]*live-owner/); |
| 165 | + assert.match(result.stdout, /agent-device daemon stop --state-dir/); |
| 166 | + } finally { |
| 167 | + fs.rmSync(claimsDir, { recursive: true, force: true }); |
| 168 | + fs.rmSync(stateDir, { recursive: true, force: true }); |
| 169 | + } |
| 170 | +}); |
| 171 | + |
| 172 | +test('device release --stale keeps the claim while durable resources cannot be settled', async () => { |
| 173 | + const claimsDir = mkdtempForTestSync('agent-device-cli-release-'); |
| 174 | + const ownerStateDir = mkdtempForTestSync('agent-device-cli-release-owner-'); |
| 175 | + try { |
| 176 | + writeClaim(claimsDir, { |
| 177 | + deviceKey: 'local:android:none:emulator-5554', |
| 178 | + id: 'emulator-5554', |
| 179 | + name: 'Dead Pixel', |
| 180 | + session: 'dead-session', |
| 181 | + ownerPid: 999_999_999, |
| 182 | + ownerStartTime: 'old-start-time', |
| 183 | + stateDir: ownerStateDir, |
| 184 | + }); |
| 185 | + // The dead owner left an attributable durable resource whose recorded |
| 186 | + // device is NOT this claim's device: exact-owner recovery refuses it, and |
| 187 | + // the claim must survive until the resource reaches a terminal state. |
| 188 | + const resourcePath = appLogResourceStore.resolvePath( |
| 189 | + path.join(ownerStateDir, 'sessions', 'dead-session'), |
| 190 | + ); |
| 191 | + appLogResourceStore.write( |
| 192 | + resourcePath, |
| 193 | + createDurableResourceEnvelope({ |
| 194 | + resourceKind: 'app-log', |
| 195 | + sessionId: 'dead-session', |
| 196 | + device: { id: 'some-other-device', family: 'android', kind: 'emulator' }, |
| 197 | + owner: localRuntimeOwner('android'), |
| 198 | + fence: { token: 'fence', generation: 1 }, |
| 199 | + lifecycle: 'open', |
| 200 | + descriptor: { version: 1, body: { pid: 123 } }, |
| 201 | + }), |
| 202 | + ); |
| 203 | + |
| 204 | + const result = await runCliCapture(['device', 'release', '--stale', '--json'], { |
| 205 | + env: { AGENT_DEVICE_CLAIMS_DIR: claimsDir }, |
| 206 | + }); |
| 207 | + const payload = JSON.parse(result.stdout); |
| 208 | + assert.equal(payload.success, true); |
| 209 | + assert.equal(payload.data.released.length, 0); |
| 210 | + assert.equal(payload.data.retained.length, 1); |
| 211 | + assert.equal(payload.data.retained[0].reason, 'app-log-owner-mismatch'); |
| 212 | + assert.equal( |
| 213 | + fs.existsSync(hashedClaimPath(claimsDir, 'local:android:none:emulator-5554')), |
| 214 | + true, |
| 215 | + ); |
| 216 | + assert.equal(fs.existsSync(resourcePath), true); |
| 217 | + } finally { |
| 218 | + fs.rmSync(claimsDir, { recursive: true, force: true }); |
| 219 | + fs.rmSync(ownerStateDir, { recursive: true, force: true }); |
| 220 | + } |
| 221 | +}); |
| 222 | + |
| 223 | +test('device release --stale keeps the claim when resource evidence is unreadable', async () => { |
| 224 | + const claimsDir = mkdtempForTestSync('agent-device-cli-release-'); |
| 225 | + const ownerStateDir = mkdtempForTestSync('agent-device-cli-release-owner-'); |
| 226 | + try { |
| 227 | + writeClaim(claimsDir, { |
| 228 | + deviceKey: 'local:android:none:emulator-5554', |
| 229 | + id: 'emulator-5554', |
| 230 | + name: 'Dead Pixel', |
| 231 | + session: 'dead-session', |
| 232 | + ownerPid: 999_999_999, |
| 233 | + ownerStartTime: 'old-start-time', |
| 234 | + stateDir: ownerStateDir, |
| 235 | + }); |
| 236 | + const resourcePath = appLogResourceStore.resolvePath( |
| 237 | + path.join(ownerStateDir, 'sessions', 'dead-session'), |
| 238 | + ); |
| 239 | + fs.mkdirSync(path.dirname(resourcePath), { recursive: true }); |
| 240 | + fs.writeFileSync(resourcePath, '{'); |
| 241 | + |
| 242 | + const result = await runCliCapture(['device', 'release', '--stale', '--json'], { |
| 243 | + env: { AGENT_DEVICE_CLAIMS_DIR: claimsDir }, |
| 244 | + }); |
| 245 | + const payload = JSON.parse(result.stdout); |
| 246 | + assert.equal(payload.data.retained.length, 1); |
| 247 | + assert.equal(payload.data.retained[0].reason, 'app-log-descriptor-invalid'); |
| 248 | + assert.equal( |
| 249 | + fs.existsSync(hashedClaimPath(claimsDir, 'local:android:none:emulator-5554')), |
| 250 | + true, |
| 251 | + ); |
| 252 | + } finally { |
| 253 | + fs.rmSync(claimsDir, { recursive: true, force: true }); |
| 254 | + fs.rmSync(ownerStateDir, { recursive: true, force: true }); |
| 255 | + } |
| 256 | +}); |
| 257 | + |
| 258 | +test('recovery is composed per claim from the stale owner state dir, never the caller', async () => { |
| 259 | + const claimsDir = mkdtempForTestSync('agent-device-cli-release-'); |
| 260 | + const ownerDirA = mkdtempForTestSync('agent-device-cli-release-owner-a-'); |
| 261 | + const ownerDirB = mkdtempForTestSync('agent-device-cli-release-owner-b-'); |
| 262 | + try { |
| 263 | + // Two dead owners with the SAME session name in different state dirs: the |
| 264 | + // adversarial shape from review — one caller-scoped store would clear the |
| 265 | + // wrong worktree's records for that session name. |
| 266 | + writeClaim(claimsDir, { |
| 267 | + deviceKey: 'local:android:none:emulator-5554', |
| 268 | + id: 'emulator-5554', |
| 269 | + name: 'Dead Pixel A', |
| 270 | + session: 'shared-session', |
| 271 | + ownerPid: 999_999_999, |
| 272 | + ownerStartTime: 'old-start-time', |
| 273 | + stateDir: ownerDirA, |
| 274 | + }); |
| 275 | + writeClaim(claimsDir, { |
| 276 | + deviceKey: 'local:android:none:emulator-5556', |
| 277 | + id: 'emulator-5556', |
| 278 | + name: 'Dead Pixel B', |
| 279 | + session: 'shared-session', |
| 280 | + ownerPid: 999_999_999, |
| 281 | + ownerStartTime: 'old-start-time', |
| 282 | + stateDir: ownerDirB, |
| 283 | + }); |
| 284 | + process.env.AGENT_DEVICE_CLAIMS_DIR = claimsDir; |
| 285 | + |
| 286 | + const composedFor: string[] = []; |
| 287 | + const outcomes = await runStaleDeviceClaimRelease({}, (stateDir) => { |
| 288 | + composedFor.push(stateDir); |
| 289 | + return { |
| 290 | + reconcile: async (claim) => { |
| 291 | + assert.equal(claim.stateDir, stateDir); |
| 292 | + return { status: 'reconciled' }; |
| 293 | + }, |
| 294 | + dispose: async () => {}, |
| 295 | + }; |
| 296 | + }); |
| 297 | + |
| 298 | + assert.deepEqual([...composedFor].sort(), [ownerDirA, ownerDirB].sort()); |
| 299 | + assert.equal(outcomes.filter((outcome) => outcome.status === 'released').length, 2); |
| 300 | + } finally { |
| 301 | + delete process.env.AGENT_DEVICE_CLAIMS_DIR; |
| 302 | + fs.rmSync(claimsDir, { recursive: true, force: true }); |
| 303 | + fs.rmSync(ownerDirA, { recursive: true, force: true }); |
| 304 | + fs.rmSync(ownerDirB, { recursive: true, force: true }); |
| 305 | + } |
| 306 | +}); |
0 commit comments