You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2960bef
Browse filesBrowse the repository at this point in the historyBrowse files
fix(batch): stamp the step session flag only when the caller named one (#3674)
The batch runner stamped flags.session on every step so nested invokes route to the
parent's resolved address. The wire `session` field already does that; the flag is a
provenance carrier, and the new named-session refusal reads it. An unconditional stamp
therefore made a sessionless batch look caller-addressed and met SESSION_NOT_FOUND at
the daemon — an error no caller of the batch surface asked for, with advice ("omit
--session") the surface does not even offer. The stamp now follows the same traced
provenance as every other carrier: meta.sessionExplicit or a caller-set step flag.
Also from the same review: the named-session disclosure row's driver now pins the
producer's own code and typed reason, so a reverted guard cannot satisfy it with the
device-selection error it replaced; commands.md states which pre-dispatch refusals
answer session_or_device_selector_required even for a named-but-unheld session.
Copy file name to clipboardExpand all lines: website/docs/docs/commands.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -484,7 +484,7 @@ Read-only commands such as `get`, `snapshot`, and `wait` report `no`, and so do
484
484
485
485
These refusals carry `dispatched: no` and a typed `error.details.reason`, so branch on the reason, not the message:
486
486
487
-
- `session_or_device_selector_required`: the request had neither an active session nor a device selector. Open a session or pass `--platform`.
487
+
- `session_or_device_selector_required`: the request had neither an active session nor a device selector. Open a session or pass `--platform`. Commands that require a session or a device selector before they read the request's target (`boot`, `clipboard`, `push`, `apps`, and siblings) answer this even when the request named a session the daemon does not hold.
488
488
- `named_session_not_found`: the request named a session this daemon does not hold, with no device selector to fall back on. The daemon lost its sessions (replaced or restarted), or the name is wrong; `agent-device session list` shows what it holds.
489
489
- `session_app_required`: a per-app setting was requested but the session binds no app and none was named. Run `open <app>`, or name the app on the request for a setting that takes one (`settings clear-app-state com.example.app`).
490
490
- `app_not_installed`: the named app resolves to no installed app on the target. Run `apps --all` for the exact bundle id or package, or install the app, then retry.
0 commit comments